Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Issue 2918093002: Update the policy documentation for sync and local sync. (Closed)

Created:
3 years, 6 months ago by pastarmovj
Modified:
3 years, 5 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the policy documentation for sync and local sync. The RoamingProfileSupportEnabled documentation was wrongly referring to a deprecated policy while the actual dependency on the SyncDisabled policy was omitted. Now the proper interconnection between the two policies is described. BUG=676619 TEST=none - documentation only change. Review-Url: https://codereview.chromium.org/2918093002 Cr-Commit-Position: refs/heads/master@{#485624} Committed: https://chromium.googlesource.com/chromium/src/+/f143b4e8b90d870ea29a2009b2045a0073cadba5

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M components/policy/resources/policy_templates.json View 1 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
pastarmovj
Hi Drew, since we discussed this with you and you know the context, can you ...
3 years, 6 months ago (2017-06-02 09:49:03 UTC) #2
Andrew T Wilson (Slow)
https://codereview.chromium.org/2918093002/diff/1/components/policy/resources/policy_templates.json File components/policy/resources/policy_templates.json (right): https://codereview.chromium.org/2918093002/diff/1/components/policy/resources/policy_templates.json#newcode1559 components/policy/resources/policy_templates.json:1559: When roaming profiles support is used the <ph name="SYNC_DISABLED_POLICY_NAME">SyncDisabled</ph> ...
3 years, 6 months ago (2017-06-14 15:05:44 UTC) #3
pastarmovj
Thanks! https://codereview.chromium.org/2918093002/diff/1/components/policy/resources/policy_templates.json File components/policy/resources/policy_templates.json (right): https://codereview.chromium.org/2918093002/diff/1/components/policy/resources/policy_templates.json#newcode1559 components/policy/resources/policy_templates.json:1559: When roaming profiles support is used the <ph ...
3 years, 5 months ago (2017-07-03 11:14:58 UTC) #4
pastarmovj
On 2017/07/03 11:14:58, pastarmovj wrote: > Thanks! > > https://codereview.chromium.org/2918093002/diff/1/components/policy/resources/policy_templates.json > File components/policy/resources/policy_templates.json (right): > ...
3 years, 5 months ago (2017-07-11 11:35:39 UTC) #5
Andrew T Wilson (Slow)
lgtm
3 years, 5 months ago (2017-07-11 12:23:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2918093002/20001
3 years, 5 months ago (2017-07-11 12:26:48 UTC) #8
commit-bot: I haz the power
3 years, 5 months ago (2017-07-11 14:29:29 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f143b4e8b90d870ea29a2009b204...

Powered by Google App Engine
This is Rietveld 408576698