Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2918063002: Revert of Add policies support to VerifyCertificateChain(). (Closed)

Created:
3 years, 6 months ago by yoichio
Modified:
3 years, 6 months ago
Reviewers:
eroman, mattm
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add policies support to VerifyCertificateChain(). (patchset #9 id:160001 of https://codereview.chromium.org/2903283002/ ) Reason for revert: This patch causes VerifyCertificateChain test failure on linux: https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/26805 Original issue's description: > Add policies support to VerifyCertificateChain(). > > Support is compliant with RFC 5280 and supports all the policy > extensions specified therein: > > * Inhibit Any Policy > * Policy Constraints > * Policies > * Policy Mappings > > Testing is done solely using the PKITS test suite, which has fairly good > coverage of these extensions: > > 4.8 (Certificate Policies) > 4.9 (Require Explicit Policy) > 4.10 (Policy Mappings) > 4.11 (Inhibit Policy Mapping) > 4.12 (Inhibit Any Policy) > > BUG=634456, 634453, 634452 > > Review-Url: https://codereview.chromium.org/2903283002 > Cr-Commit-Position: refs/heads/master@{#476513} > Committed: https://chromium.googlesource.com/chromium/src/+/bcca0368ac116828cecc6c68a381bfc5147f8c98 TBR=mattm@chromium.org,eroman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=634456, 634453, 634452 Review-Url: https://codereview.chromium.org/2918063002 Cr-Commit-Position: refs/heads/master@{#476562} Committed: https://chromium.googlesource.com/chromium/src/+/854d102a9172d20548a8e8a1b5310e02dfeb9759

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -951 lines) Patch
M net/cert/internal/nist_pkits_unittest.h View 1 chunk +3 lines, -5 lines 0 comments Download
M net/cert/internal/nist_pkits_unittest.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M net/cert/internal/path_builder.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M net/cert/internal/test_helpers.h View 1 chunk +0 lines, -10 lines 0 comments Download
M net/cert/internal/test_helpers.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/cert/internal/verify_certificate_chain.h View 3 chunks +41 lines, -136 lines 0 comments Download
M net/cert/internal/verify_certificate_chain.cc View 20 chunks +139 lines, -742 lines 0 comments Download
M net/cert/internal/verify_certificate_chain_pkits_unittest.cc View 3 chunks +7 lines, -25 lines 0 comments Download
M net/cert/internal/verify_certificate_chain_unittest.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M net/third_party/nist-pkits/generate_tests.py View 2 chunks +2 lines, -11 lines 0 comments Download
M net/third_party/nist-pkits/pkits_testcases-inl.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
yoichio
Created Revert of Add policies support to VerifyCertificateChain().
3 years, 6 months ago (2017-06-02 04:29:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2918063002/1
3 years, 6 months ago (2017-06-02 04:29:23 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/854d102a9172d20548a8e8a1b5310e02dfeb9759
3 years, 6 months ago (2017-06-02 04:30:01 UTC) #6
eroman
3 years, 6 months ago (2017-06-02 18:48:07 UTC) #7
Message was sent while issue was closed.
Thanks for the revert yoichio!

Looks like debug builds fail on:
   std::iter_swap(x, x);

(i.e. swapping with self).

Powered by Google App Engine
This is Rietveld 408576698