Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 2918043003: Log eventlogs from legacy isolate archive command (Closed)

Created:
3 years, 6 months ago by mcgreevy
Modified:
3 years, 6 months ago
Reviewers:
mcgreevy_g, mithro
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Log eventlogs from legacy isolate archive command. This change also refactors some of the eventlogging code so that it can be used my multiple subcommands. Also, tests! BUG=727985 Review-Url: https://codereview.chromium.org/2918043003 Committed: https://github.com/luci/luci-go/commit/e4c28c843ad9c957d7d3bde039ca8ccfe033b5de

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -69 lines) Patch
M client/cmd/isolate/archive.go View 3 chunks +21 lines, -1 line 0 comments Download
M client/cmd/isolate/exp_archive.go View 3 chunks +11 lines, -68 lines 0 comments Download
A client/cmd/isolate/isolate_event_logger.go View 1 1 chunk +100 lines, -0 lines 0 comments Download
A client/cmd/isolate/isolate_event_logger_test.go View 1 1 chunk +96 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
mcgreevy
@tansell please take a look.
3 years, 6 months ago (2017-06-02 05:48:09 UTC) #3
mithro
Generally LGTM, some minor comments. What about batcharchive, is that going to be in a ...
3 years, 6 months ago (2017-06-02 06:52:58 UTC) #4
mcgreevy_g
PTAL https://codereview.chromium.org/2918043003/diff/1/client/cmd/isolate/isolate_event_logger.go File client/cmd/isolate/isolate_event_logger.go (right): https://codereview.chromium.org/2918043003/diff/1/client/cmd/isolate/isolate_event_logger.go#newcode18 client/cmd/isolate/isolate_event_logger.go:18: type synclogger interface { On 2017/06/02 06:52:55, mithro ...
3 years, 6 months ago (2017-06-02 07:04:43 UTC) #6
mithro
LGTM.
3 years, 6 months ago (2017-06-02 07:19:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2918043003/20001
3 years, 6 months ago (2017-06-05 00:27:51 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-05 00:34:01 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/e4c28c843ad9c957d7d3bde039ca8ccfe033b5de

Powered by Google App Engine
This is Rietveld 408576698