Log eventlogs from legacy isolate archive command

Log eventlogs from legacy isolate archive command.

This change also refactors some of the eventlogging code so that it can be used my multiple subcommands.  Also, tests!

BUG=727985
Review-Url: https://codereview.chromium.org/2918043003
Committed: https://github.com/luci/luci-go/commit/e4c28c843ad9c957d7d3bde039ca8ccfe033b5de

[mcgreevy, 2017-06-02 05:10:46]

Description was changed from

==========
Log eventlogs from legacy isolate archive command

BUG=727985
==========

to

==========
Log eventlogs from legacy isolate archive command.

This change also refactors some of the eventlogging code so that it can be used
my multiple subcommands.  Also, tests!

BUG=727985
==========

[mcgreevy, 2017-06-02 05:10:46]

mcgreevy@chromium.org changed reviewers:
+ tansell@chromium.org

[mcgreevy, 2017-06-02 05:48:09]

@tansell please take a look.

[mithro, 2017-06-02 06:52:58]

Generally LGTM, some minor comments.

What about batcharchive, is that going to be in a different CL?

https://codereview.chromium.org/2918043003/diff/1/client/cmd/isolate/isolate_...
File client/cmd/isolate/isolate_event_logger.go (right):

https://codereview.chromium.org/2918043003/diff/1/client/cmd/isolate/isolate_...
client/cmd/isolate/isolate_event_logger.go:18: type synclogger interface {
Should this be syncLogger ?

https://codereview.chromium.org/2918043003/diff/1/client/cmd/isolate/isolate_...
client/cmd/isolate/isolate_event_logger.go:23: // An IsolateEventLogger logs
eventlogs which describe an isolate run.
This sentence doesn't read quite right.

https://codereview.chromium.org/2918043003/diff/1/client/cmd/isolate/isolate_...
client/cmd/isolate/isolate_event_logger.go:82: // getBuildbotInfo poulates a
buildbotInfo with information from the environment.
Buildbot or BuildBot?

[mcgreevy_g, 2017-06-02 07:04:42]

mcgreevy@google.com changed reviewers:
+ mcgreevy@google.com

[mcgreevy_g, 2017-06-02 07:04:43]

PTAL

https://codereview.chromium.org/2918043003/diff/1/client/cmd/isolate/isolate_...
File client/cmd/isolate/isolate_event_logger.go (right):

https://codereview.chromium.org/2918043003/diff/1/client/cmd/isolate/isolate_...
client/cmd/isolate/isolate_event_logger.go:18: type synclogger interface {
On 2017/06/02 06:52:55, mithro wrote:
> Should this be syncLogger ?

Done.

https://codereview.chromium.org/2918043003/diff/1/client/cmd/isolate/isolate_...
client/cmd/isolate/isolate_event_logger.go:23: // An IsolateEventLogger logs
eventlogs which describe an isolate run.
On 2017/06/02 06:52:55, mithro wrote:
> This sentence doesn't read quite right. 

It's hard when "isolate" is both a verb and noun.

Better?

https://codereview.chromium.org/2918043003/diff/1/client/cmd/isolate/isolate_...
client/cmd/isolate/isolate_event_logger.go:82: // getBuildbotInfo poulates a
buildbotInfo with information from the environment.
On 2017/06/02 06:52:55, mithro wrote:
> Buildbot or BuildBot?

Buildbot; it's one word -- I checked.

[mithro, 2017-06-02 07:19:57]

LGTM.

[mcgreevy, 2017-06-05 00:27:41]

The CQ bit was checked by mcgreevy@chromium.org

[commit-bot: I haz the power, 2017-06-05 00:27:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 00:33:57]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496622461580530,
"parent_rev": "1c9bfc6dd8d53a83332efae04b25611bb560660f", "commit_rev":
"e4c28c843ad9c957d7d3bde039ca8ccfe033b5de"}

[commit-bot: I haz the power, 2017-06-05 00:34:00]

Description was changed from

==========
Log eventlogs from legacy isolate archive command.

This change also refactors some of the eventlogging code so that it can be used
my multiple subcommands.  Also, tests!

BUG=727985
==========

to

==========
Log eventlogs from legacy isolate archive command.

This change also refactors some of the eventlogging code so that it can be used
my multiple subcommands.  Also, tests!

BUG=727985

Review-Url: https://codereview.chromium.org/2918043003
Committed:
https://github.com/luci/luci-go/commit/e4c28c843ad9c957d7d3bde039ca8ccfe033b5de
==========

[commit-bot: I haz the power, 2017-06-05 00:34:01]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/e4c28c843ad9c957d7d3bde039ca8ccfe033b5de