Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2918033003: Input type check comparision should be an ASCII case-insensitive match. (Closed)

Created:
3 years, 6 months ago by tanvir
Modified:
3 years, 6 months ago
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Input type check comparision should be an ASCII case-insensitive match. Currently we use unicode-careless matching,which is wrong. so ASCII -caseless matching is used now. BUG=728515 Review-Url: https://codereview.chromium.org/2918033003 Cr-Commit-Position: refs/heads/master@{#477786} Committed: https://chromium.googlesource.com/chromium/src/+/b1bf7d6b39cc77b38b433873a3db686dc3a0ca73

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated Patch #

Total comments: 1

Patch Set 3 : updated patchset 2 #

Patch Set 4 : updated patch#3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -13 lines) Patch
M third_party/WebKit/LayoutTests/external/wpt/html/dom/reflection-forms-expected.txt View 1 2 3 1 chunk +2 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/input-type-change3.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/input-type-change3-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/InputType.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 29 (20 generated)
tkent
https://codereview.chromium.org/2918033003/diff/1/third_party/WebKit/Source/core/html/forms/InputType.cpp File third_party/WebKit/Source/core/html/forms/InputType.cpp (right): https://codereview.chromium.org/2918033003/diff/1/third_party/WebKit/Source/core/html/forms/InputType.cpp#newcode140 third_party/WebKit/Source/core/html/forms/InputType.cpp:140: FactoryMap()->find(AtomicString(type_name.Ascii().data())); As the try bots showed failures, this change ...
3 years, 6 months ago (2017-06-05 00:27:50 UTC) #9
tanvir
Changes done as per review comments. PTAL ! Thanks
3 years, 6 months ago (2017-06-05 16:16:04 UTC) #15
tkent
C++ code change is ok. https://codereview.chromium.org/2918033003/diff/40001/third_party/WebKit/LayoutTests/fast/forms/input-type-valid-attributes.html File third_party/WebKit/LayoutTests/fast/forms/input-type-valid-attributes.html (right): https://codereview.chromium.org/2918033003/diff/40001/third_party/WebKit/LayoutTests/fast/forms/input-type-valid-attributes.html#newcode1 third_party/WebKit/LayoutTests/fast/forms/input-type-valid-attributes.html:1: <!DOCTYPE html> This should ...
3 years, 6 months ago (2017-06-06 07:05:58 UTC) #16
tanvir
On 2017/06/06 07:05:58, tkent wrote: > C++ code change is ok. > > https://codereview.chromium.org/2918033003/diff/40001/third_party/WebKit/LayoutTests/fast/forms/input-type-valid-attributes.html > ...
3 years, 6 months ago (2017-06-07 08:20:08 UTC) #17
tkent
Please update test result of LayoutTests/external/wpt/html/dom/reflection-forms.html.
3 years, 6 months ago (2017-06-07 08:22:25 UTC) #18
tanvir
On 2017/06/07 08:22:25, tkent wrote: > Please update test result of > LayoutTests/external/wpt/html/dom/reflection-forms.html. Done. PTAL!!! ...
3 years, 6 months ago (2017-06-07 14:19:24 UTC) #21
tkent
lgtm
3 years, 6 months ago (2017-06-07 21:32:57 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2918033003/80001
3 years, 6 months ago (2017-06-07 21:33:19 UTC) #26
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 23:28:50 UTC) #29
Message was sent while issue was closed. 
Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/b1bf7d6b39cc77b38b433873a3db...

Powered by Google App Engine
This is Rietveld 408576698