Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 291803003: Unconditionally include <string> and <iostream> in json_reader.cpp (Closed)

Created:
6 years, 7 months ago by Alexander Potapenko
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Unconditionally include <string> and <iostream> in json_reader.cpp Non-PNaCl builds that use libc++ also require these headers. BUG=None R=mallinath@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271429

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M third_party/jsoncpp/overrides/src/lib_json/json_reader.cpp View 1 chunk +2 lines, -4 lines 1 comment Download

Messages

Total messages: 8 (0 generated)
Alexander Potapenko
PTAL
6 years, 7 months ago (2014-05-19 09:00:05 UTC) #1
pbos
On 2014/05/19 09:00:05, Alexander Potapenko wrote: > PTAL drive-by lgtm. mallinath@ for context this un-breaks ...
6 years, 7 months ago (2014-05-19 09:24:43 UTC) #2
Mallinath (Gone from Chromium)
lgtm
6 years, 7 months ago (2014-05-19 15:13:29 UTC) #3
Alexander Potapenko
The CQ bit was checked by glider@chromium.org
6 years, 7 months ago (2014-05-19 15:46:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/291803003/1
6 years, 7 months ago (2014-05-19 15:46:54 UTC) #5
commit-bot: I haz the power
Change committed as 271429
6 years, 7 months ago (2014-05-19 18:24:22 UTC) #6
Nico
A revert of this CL has been created in https://codereview.chromium.org/290923003/ by thakis@chromium.org. The reason for ...
6 years, 7 months ago (2014-05-19 19:05:10 UTC) #7
Nico
6 years, 7 months ago (2014-05-19 19:23:04 UTC) #8
Message was sent while issue was closed.
https://codereview.chromium.org/291803003/diff/1/third_party/jsoncpp/override...
File third_party/jsoncpp/overrides/src/lib_json/json_reader.cpp (right):

https://codereview.chromium.org/291803003/diff/1/third_party/jsoncpp/override...
third_party/jsoncpp/overrides/src/lib_json/json_reader.cpp:21: // but defines it
in <iostream>. The code therefore fails linking, which
As iostream causes static initializers, that seems like a bug in libc++. It
should be defined in some other stream header probably.

Powered by Google App Engine
This is Rietveld 408576698