Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2917923004: Move handler processing to NotificationDisplayService

Created:
3 years, 6 months ago by Miguel Garcia
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews, extensions-reviews_chromium.org, awdf+watch_chromium.org, Peter Beverloo, mlamouri+watch-notifications_chromium.org, jam, darin-cc_chromium.org, mac-reviews_chromium.org, chromium-apps-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move handler processing to NotificationDisplayService BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -110 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/notifications/extension_notification_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/notifications/extension_notification_handler.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/notifications/message_center_display_service.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/notifications/native_notification_display_service.h View 3 chunks +0 lines, -23 lines 0 comments Download
M chrome/browser/notifications/native_notification_display_service.cc View 5 chunks +4 lines, -64 lines 0 comments Download
M chrome/browser/notifications/non_persistent_notification_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/notifications/non_persistent_notification_handler.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/notifications/notification_display_service.h View 4 chunks +32 lines, -2 lines 0 comments Download
A chrome/browser/notifications/notification_display_service.cc View 1 chunk +73 lines, -0 lines 0 comments Download
M chrome/browser/notifications/notification_handler.h View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/notifications/notification_platform_bridge_android.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/notifications/notification_platform_bridge_linux.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/notifications/notification_platform_bridge_mac.mm View 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/notifications/persistent_notification_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/notifications/persistent_notification_handler.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/notifications/stub_notification_display_service.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/notifications/stub_notification_display_service.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M content/browser/notifications/notification_event_dispatcher_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (4 generated)
Miguel Garcia
The CQ bit was checked by miguelg@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-02 15:25:07 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2917923004/1
3 years, 6 months ago (2017-06-02 15:25:23 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-02 17:01:47 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 17:01:48 UTC) #4 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698