Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 2917883002: Do not fire multiple password reuse events for the same page. (Closed)

Created:
3 years, 6 months ago by dvadym
Modified:
3 years, 6 months ago
Reviewers:
vasilii
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not fire multiple password reuse events for the same page. BUG=657041 Review-Url: https://codereview.chromium.org/2917883002 Cr-Commit-Position: refs/heads/master@{#476309} Committed: https://chromium.googlesource.com/chromium/src/+/059baeae2336c0583a22036a864e9795dae213eb

Patch Set 1 #

Patch Set 2 : comment fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -3 lines) Patch
M components/password_manager/core/browser/password_reuse_detection_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/password_manager/core/browser/password_reuse_detection_manager.cc View 1 3 chunks +14 lines, -3 lines 0 comments Download
M components/password_manager/core/browser/password_reuse_detection_manager_unittest.cc View 1 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
dvadym
hi Vasilii, could you please review this CL? Regards, Vadym
3 years, 6 months ago (2017-06-01 13:58:08 UTC) #3
vasilii
lgtm
3 years, 6 months ago (2017-06-01 14:28:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2917883002/20001
3 years, 6 months ago (2017-06-01 14:36:09 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 15:54:24 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/059baeae2336c0583a22036a864e...

Powered by Google App Engine
This is Rietveld 408576698