Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Issue 2917853004: [heap] Activate memory reducer on external memory activity. (Closed)

Created:
3 years, 6 months ago by Hannes Payer (out of office)
Modified:
3 years, 6 months ago
Reviewers:
Michael Lippautz, ulan
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Activate memory reducer on external memory activity. BUG=chromium:728228, chromium:626082 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng Review-Url: https://codereview.chromium.org/2917853004 Cr-Commit-Position: refs/heads/master@{#45671} Committed: https://chromium.googlesource.com/v8/v8/+/502c6ae6a03979efbd3e006e6a0b8c3369ca2bbc

Patch Set 1 #

Total comments: 2

Patch Set 2 : naming #

Patch Set 3 : check for memory_reducer_ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -4 lines) Patch
M include/v8.h View 1 3 chunks +18 lines, -0 lines 0 comments Download
M src/api.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 2 1 chunk +6 lines, -4 lines 0 comments Download
M src/isolate.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
Hannes Payer (out of office)
3 years, 6 months ago (2017-06-01 18:43:02 UTC) #3
Michael Lippautz
LGTM https://codereview.chromium.org/2917853004/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/2917853004/diff/1/include/v8.h#newcode10048 include/v8.h:10048: const int64_t memory_reducer_activation_limit = 1024 * 1024; kMemoryReducerActivationLimit ...
3 years, 6 months ago (2017-06-01 18:47:06 UTC) #6
Hannes Payer (out of office)
https://codereview.chromium.org/2917853004/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/2917853004/diff/1/include/v8.h#newcode10048 include/v8.h:10048: const int64_t memory_reducer_activation_limit = 1024 * 1024; On 2017/06/01 ...
3 years, 6 months ago (2017-06-02 06:59:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2917853004/20001
3 years, 6 months ago (2017-06-02 07:23:52 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: v8_node_linux64_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_node_linux64_rel/builds/2888)
3 years, 6 months ago (2017-06-02 07:52:45 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2917853004/40001
3 years, 6 months ago (2017-06-02 08:54:20 UTC) #19
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 09:40:24 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/502c6ae6a03979efbd3e006e6a0b8c3369c...

Powered by Google App Engine
This is Rietveld 408576698