Issue 2917823004: Default to BBR congestion control for QUIC. Protected by

Issue 2917823004: Default to BBR congestion control for QUIC. Protected by (Closed)

Created:
3 years, 6 months ago by Jana

Modified:
3 years, 6 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Default to BBR congestion control for QUIC. Protected by FLAGS_quic_reloadable_flag_quic_default_to_bbr. Merge internal change: 157287886 R=rch@chromium.org BUG=

Patch Set 2 : Rebased CL #

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -4 lines)			Patch
M	net/quic/core/quic_connection.cc	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	net/quic/core/quic_flags_list.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	net/quic/core/quic_sent_packet_manager.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	net/quic/test_tools/simulator/quic_endpoint_test.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	net/tools/quic/end_to_end_test.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download

Depends on Patchset:

Issue 2916233002 Patch 1

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

This seems to be 2 CLs? https://codereview.chromium.org/2917823004/diff/1/net/quic/core/quic_session.h File net/quic/core/quic_session.h (right): https://codereview.chromium.org/2917823004/diff/1/net/quic/core/quic_session.h#newcode221 net/quic/core/quic_session.h:221: void OnStreamDoneWaitingForAcks(QuicStreamId id); ...

3 years, 6 months ago (2017-06-01 15:23:40 UTC) #2

Jana

On 2017/06/01 15:23:40, Ryan Hamilton wrote: > This seems to be 2 CLs? > > ...

3 years, 6 months ago (2017-06-02 00:02:46 UTC) #3

lgtm

Expand Messages | Collapse Messages