Issue 2916233002: Remove is_deletable_ from QuicStream. Add QuicStream::IsWaitingForAcks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2916233002: Remove is_deletable_ from QuicStream. Add QuicStream::IsWaitingForAcks (Closed)

Created:
3 years, 6 months ago by Jana

Modified:
3 years, 6 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove is_deletable_ from QuicStream. Add QuicStream::IsWaitingForAcks which returns true if stream is waiting for acks. Merge internal change: 157256038 R=rch@chromium.org BUG=

Patch Set 1 #

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+112 lines, -85 lines)			Patch
M	net/quic/core/quic_session.h	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	net/quic/core/quic_session.cc	View	4 chunks	+6 lines, -11 lines	0 comments	Download
M	net/quic/core/quic_session_test.cc	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	net/quic/core/quic_spdy_stream_test.cc	View	2 chunks	+20 lines, -0 lines	0 comments	Download
M	net/quic/core/quic_stream.h	View	4 chunks	+6 lines, -11 lines	0 comments	Download
M	net/quic/core/quic_stream.cc	View	8 chunks	+24 lines, -29 lines	0 comments	Download
M	net/quic/core/quic_stream_test.cc	View	5 chunks	+47 lines, -27 lines	0 comments	Download

Depends on Patchset:

Issue 2919733002 Patch 1

Dependent Patchsets:

Issue 2917823004 Patch 20001

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages