Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2917823003: Revert of Remove a frame of delay on main-thread FlingStart. (Closed)

Created:
3 years, 6 months ago by Peter Kasting
Modified:
3 years, 6 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, kinuko+watch, rjwright, shans
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove a frame of delay on main-thread FlingStart. (patchset #1 id:1 of https://codereview.chromium.org/2908073008/ ) Reason for revert: Possible cause of flakiness in fast/events/touch/gesture/pad-gesture-fling.html ; see e.g. https://luci-milo.appspot.com/buildbot/chromium.webkit/WebKit%20Mac10.11%20%28dbg%29/8992 . Original issue's description: > Remove a frame of delay on main-thread FlingStart. > > Main-thread flings were waiting for the first frame of animation to > populate the start timestamp, and only on the second frame would they > start animating. But the start timestamp is included in the FlingStart > event, so there's no need for this (perhaps it was written that way for > historical reasons when the event timestamp wasn't populated properly). > > This problem was extremely noticeable in prototype of middle-click autoscroll > that issues a FlingStart on every MouseMove to change velocity, but > the fix should also benefit touchscreen and touchpad flings slightly. > > BUG=727964 > > Review-Url: https://codereview.chromium.org/2908073008 > Cr-Commit-Position: refs/heads/master@{#475984} > Committed: https://chromium.googlesource.com/chromium/src/+/3562f1b7410b884e07bbd2fc75cfee7e96ed2a41 TBR=jbroman@chromium.org,dtapuska@chromium.org,aelias@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=727964 Review-Url: https://codereview.chromium.org/2917823003 Cr-Commit-Position: refs/heads/master@{#476181} Committed: https://chromium.googlesource.com/chromium/src/+/0c284454162c7b36d587707af42828f41336904f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -10 lines) Patch
M third_party/WebKit/LayoutTests/fast/scroll-behavior/scroll-customization/touch-scroll-customization.html View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebActiveGestureAnimation.h View 2 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/exported/WebActiveGestureAnimation.cpp View 2 chunks +20 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Peter Kasting
Created Revert of Remove a frame of delay on main-thread FlingStart.
3 years, 6 months ago (2017-06-01 03:54:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2917823003/1
3 years, 6 months ago (2017-06-01 03:55:10 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 03:55:39 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0c284454162c7b36d587707af428...

Powered by Google App Engine
This is Rietveld 408576698