Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 2917773002: Remove the chrome flag to show/hide ARC files app in launcher. (Closed)

Created:
3 years, 6 months ago by xutan
Modified:
3 years, 6 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, asvitkine+watch_chromium.org, tfarina, hidehiko+watch_chromium.org, Matt Giuca, lhchavez+watch_chromium.org, victorhsieh+watch_chromium.org, yusukes+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the chrome flag to show/hide ARC files app in launcher. This reverts commit eb85d566226621ba40a61a3e10fa7d6aeae091ad. This reverts commit bc979776bf3949f8111d18f3e476833de024d8e1. BUG=728344 TEST=unit_tests --gtest_filter="*AboutFlagsHistogramTest*" Review-Url: https://codereview.chromium.org/2917773002 Cr-Commit-Position: refs/heads/master@{#476154} Committed: https://chromium.googlesource.com/chromium/src/+/c957fa5c49f17ebaf4ffda4b2c3427c37353ef40

Patch Set 1 #

Total comments: 2

Patch Set 2 : Keep histogram enums. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -29 lines) Patch
M chrome/browser/about_flags.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/flag_descriptions.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/flag_descriptions.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_utils.cc View 3 chunks +1 line, -8 lines 0 comments Download
M components/arc/arc_features.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/arc/arc_features.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
xutan
Remove the chrome flag for Android Files app. Files app change is already reverted in ...
3 years, 6 months ago (2017-05-31 21:30:03 UTC) #2
Alexei Svitkine (slow)
lgtm % comment https://codereview.chromium.org/2917773002/diff/1/tools/metrics/histograms/enums.xml File tools/metrics/histograms/enums.xml (left): https://codereview.chromium.org/2917773002/diff/1/tools/metrics/histograms/enums.xml#oldcode21503 tools/metrics/histograms/enums.xml:21503: - <int value="-2134333982" label="ShowArcFilesApp:enabled"/> Keep these ...
3 years, 6 months ago (2017-05-31 21:34:52 UTC) #3
xutan
https://codereview.chromium.org/2917773002/diff/1/tools/metrics/histograms/enums.xml File tools/metrics/histograms/enums.xml (left): https://codereview.chromium.org/2917773002/diff/1/tools/metrics/histograms/enums.xml#oldcode21503 tools/metrics/histograms/enums.xml:21503: - <int value="-2134333982" label="ShowArcFilesApp:enabled"/> On 2017/05/31 21:34:52, Alexei Svitkine ...
3 years, 6 months ago (2017-05-31 21:55:37 UTC) #6
Yusuke Sato
lgtm
3 years, 6 months ago (2017-05-31 21:56:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2917773002/20001
3 years, 6 months ago (2017-05-31 22:04:03 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/452543)
3 years, 6 months ago (2017-05-31 22:19:16 UTC) #12
stevenjb
lgtm
3 years, 6 months ago (2017-05-31 23:22:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2917773002/20001
3 years, 6 months ago (2017-06-01 00:27:53 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 02:20:10 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c957fa5c49f17ebaf4ffda4b2c34...

Powered by Google App Engine
This is Rietveld 408576698