Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2917733002: Remove unused chrome://large-icon (Closed)

Created:
3 years, 6 months ago by pkotwicz
Modified:
3 years, 6 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused chrome://large-icon chrome://large-icon is no longer used now that Android uses native UI for history. References to chrome://large-icon were removed in https://codereview.chromium.org/2830983005 BUG=724161 Review-Url: https://codereview.chromium.org/2917733002 Cr-Commit-Position: refs/heads/master@{#477331} Committed: https://chromium.googlesource.com/chromium/src/+/e4030d6daba664202cae56cdfb0de6da75e9038b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -379 lines) Patch
M chrome/browser/ui/BUILD.gn View 1 chunk +1 line, -6 lines 0 comments Download
M chrome/browser/ui/webui/browsing_history_handler.cc View 2 chunks +0 lines, -8 lines 0 comments Download
D chrome/browser/ui/webui/large_icon_source.h View 1 chunk +0 lines, -76 lines 0 comments Download
D chrome/browser/ui/webui/large_icon_source.cc View 1 chunk +0 lines, -130 lines 0 comments Download
M chrome/common/url_constants.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/url_constants.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/favicon_base/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
D components/favicon_base/large_icon_url_parser.h View 1 chunk +0 lines, -48 lines 0 comments Download
D components/favicon_base/large_icon_url_parser.cc View 1 chunk +0 lines, -43 lines 0 comments Download
D components/favicon_base/large_icon_url_parser_unittest.cc View 1 chunk +0 lines, -63 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
pkotwicz
dbeam@ can you please take a look? Based on offline discussion it does not look ...
3 years, 6 months ago (2017-05-31 20:04:41 UTC) #2
Dan Beam
i'm not sure i followed the conversation super closely, but if we can remove an ...
3 years, 6 months ago (2017-06-06 02:18:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2917733002/1
3 years, 6 months ago (2017-06-06 15:28:34 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 17:45:23 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e4030d6daba664202cae56cdfb0d...

Powered by Google App Engine
This is Rietveld 408576698