Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2917713002: Teach input_handler_proxy about once callbacks. (Closed)

Created:
3 years, 6 months ago by dtapuska
Modified:
3 years, 6 months ago
Reviewers:
chongz
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, dtapuska+chromiumwatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Teach input_handler_proxy about once callbacks. Use OnceCallbacks inside the input handler proxy so that in the future we are able to bind to a mojo callback. BUG=722928 Review-Url: https://codereview.chromium.org/2917713002 Cr-Commit-Position: refs/heads/master@{#476052} Committed: https://chromium.googlesource.com/chromium/src/+/3fc40f87a4f860d97cdd75aa398b70249dae6c3a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -24 lines) Patch
M content/renderer/input/input_handler_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/events/blink/event_with_callback.h View 1 chunk +5 lines, -6 lines 0 comments Download
M ui/events/blink/event_with_callback.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M ui/events/blink/input_handler_proxy.h View 1 chunk +7 lines, -8 lines 0 comments Download
M ui/events/blink/input_handler_proxy.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (5 generated)
dtapuska
3 years, 6 months ago (2017-05-31 17:13:40 UTC) #3
chongz
LGTM thanks for the patch!
3 years, 6 months ago (2017-05-31 17:51:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2917713002/1
3 years, 6 months ago (2017-05-31 18:39:01 UTC) #6
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 22:00:20 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3fc40f87a4f860d97cdd75aa398b...

Powered by Google App Engine
This is Rietveld 408576698