Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2917703003: [ios] Remove hitTest UIKit workaround. (Closed)

Created:
3 years, 6 months ago by justincohen
Modified:
3 years, 6 months ago
CC:
chromium-reviews, jdonnelly+watch_chromium.org, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Remove hitTest UIKit workaround. leftView bug appears fixed in iOS 9 and 10. BUG=546295 TEST=make sure tapping near (usually 50px to the right) the omnibox leftView (page info) doesn't incorrectly fire it. Review-Url: https://codereview.chromium.org/2917703003 Cr-Commit-Position: refs/heads/master@{#476290} Committed: https://chromium.googlesource.com/chromium/src/+/d78c189fb8e7d5792fd53a91f64c6a158b0f510a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -20 lines) Patch
M ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm View 1 chunk +1 line, -20 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
justincohen
ptal
3 years, 6 months ago (2017-06-01 01:26:36 UTC) #2
Justin Donnelly
Nice! lgtm
3 years, 6 months ago (2017-06-01 13:49:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2917703003/1
3 years, 6 months ago (2017-06-01 14:19:56 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 15:00:03 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d78c189fb8e7d5792fd53a91f64c...

Powered by Google App Engine
This is Rietveld 408576698