Add a menu item to toggle the incognito mode in ios_web_view_shell.

Expand ios_web_view_shell menu functionality.

- Add a menu item to toggle the incognito mode in ios_web_view_shell.
- Change "Deallocate web view" menu item to "Recreate web view".

These makes it easy to test these features.

Review-Url: https://codereview.chromium.org/2917583002
Cr-Commit-Position: refs/heads/master@{#476134}
Committed: https://chromium.googlesource.com/chromium/src/+/4c218107068b3358f3c65c729b412fdd4dc2cc45

[Hiroshi Ichikawa, 2017-05-31 05:11:18]

ichikawa@chromium.org changed reviewers:
+ michaeldo@chromium.org

[michaeldo, 2017-05-31 21:21:10]

LGTM Thank you for updating the shell!

nit: Can you update the title & first description line to something more
inclusive like "Expand ios_web_view_shell menu functionality." Then mention
adding the toggle for incognito and changing dealloc to recreate web view?

https://codereview.chromium.org/2917583002/diff/1/ios/web_view/shell/shell_vi...
File ios/web_view/shell/shell_view_controller.m (right):

https://codereview.chromium.org/2917583002/diff/1/ios/web_view/shell/shell_vi...
ios/web_view/shell/shell_view_controller.m:41: @property(nonatomic) BOOL
isIncognito;
I actually think it would be better to either use
!_webView.configuration.isPersistent directly or make this readonly and return
that value so we don't need to worry about setting it.

https://codereview.chromium.org/2917583002/diff/1/ios/web_view/shell/shell_vi...
ios/web_view/shell/shell_view_controller.m:163: [self
createWebViewWithConfiguration:[self createConfiguration]];
I think explicitly using [CWVWebViewConfiguration defaultConfiguration] here is
clearer about the default state and that helper method can be removed.

https://codereview.chromium.org/2917583002/diff/1/ios/web_view/shell/shell_vi...
ios/web_view/shell/shell_view_controller.m:235: // and sharing configuration,
because there have been multiple bugs on these
I think you can remove the ", because there have been multiple bugs on these
features" piece of this comment. Testing the feature in the shell is a good idea
even if there were never any bugs in them :)

https://codereview.chromium.org/2917583002/diff/1/ios/web_view/shell/shell_vi...
ios/web_view/shell/shell_view_controller.m:252: -
(CWVWebViewConfiguration*)createConfiguration {
Per comment above, I don't think we need this. We can just toggle in the handler
block above.

[Hiroshi Ichikawa, 2017-06-01 01:01:59]

Description was changed from

==========
Add a menu item to toggle the incognito mode in ios_web_view_shell.

Also change "Deallocate web view" menu item to "Recreate web view".

These makes it easy to test these features.
==========

to

==========
Expand ios_web_view_shell menu functionality.

- Add a menu item to toggle the incognito mode in ios_web_view_shell.
- Change "Deallocate web view" menu item to "Recreate web view".

These makes it easy to test these features.
==========

[Hiroshi Ichikawa, 2017-06-01 01:20:37]

https://codereview.chromium.org/2917583002/diff/1/ios/web_view/shell/shell_vi...
File ios/web_view/shell/shell_view_controller.m (right):

https://codereview.chromium.org/2917583002/diff/1/ios/web_view/shell/shell_vi...
ios/web_view/shell/shell_view_controller.m:41: @property(nonatomic) BOOL
isIncognito;
On 2017/05/31 21:21:10, michaeldo wrote:
> I actually think it would be better to either use
> !_webView.configuration.isPersistent directly or make this readonly and return
> that value so we don't need to worry about setting it.

Done.

https://codereview.chromium.org/2917583002/diff/1/ios/web_view/shell/shell_vi...
ios/web_view/shell/shell_view_controller.m:163: [self
createWebViewWithConfiguration:[self createConfiguration]];
On 2017/05/31 21:21:09, michaeldo wrote:
> I think explicitly using [CWVWebViewConfiguration defaultConfiguration] here
is
> clearer about the default state and that helper method can be removed.

Done.

https://codereview.chromium.org/2917583002/diff/1/ios/web_view/shell/shell_vi...
ios/web_view/shell/shell_view_controller.m:235: // and sharing configuration,
because there have been multiple bugs on these
On 2017/05/31 21:21:10, michaeldo wrote:
> I think you can remove the ", because there have been multiple bugs on these
> features" piece of this comment. Testing the feature in the shell is a good
idea
> even if there were never any bugs in them :)

Done.

https://codereview.chromium.org/2917583002/diff/1/ios/web_view/shell/shell_vi...
ios/web_view/shell/shell_view_controller.m:252: -
(CWVWebViewConfiguration*)createConfiguration {
On 2017/05/31 21:21:10, michaeldo wrote:
> Per comment above, I don't think we need this. We can just toggle in the
handler
> block above.

Done. I also extracted -toggleIncognito as a method because it became longer.

[Hiroshi Ichikawa, 2017-06-01 01:20:43]

The CQ bit was checked by ichikawa@chromium.org

[Hiroshi Ichikawa, 2017-06-01 01:20:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaeldo@chromium.org
Link to the patchset: https://codereview.chromium.org/2917583002/#ps20001
(title: "Apply review comments.")

[commit-bot: I haz the power, 2017-06-01 01:21:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 01:34:50]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496280043376900,
"parent_rev": "747aeede10c629f405aa7a7ad1f1d9f96c1c5ea6", "commit_rev":
"4c218107068b3358f3c65c729b412fdd4dc2cc45"}

[commit-bot: I haz the power, 2017-06-01 01:34:59]

Description was changed from

==========
Expand ios_web_view_shell menu functionality.

- Add a menu item to toggle the incognito mode in ios_web_view_shell.
- Change "Deallocate web view" menu item to "Recreate web view".

These makes it easy to test these features.
==========

to

==========
Expand ios_web_view_shell menu functionality.

- Add a menu item to toggle the incognito mode in ios_web_view_shell.
- Change "Deallocate web view" menu item to "Recreate web view".

These makes it easy to test these features.

Review-Url: https://codereview.chromium.org/2917583002
Cr-Commit-Position: refs/heads/master@{#476134}
Committed:
https://chromium.googlesource.com/chromium/src/+/4c218107068b3358f3c65c729b41...
==========

[commit-bot: I haz the power, 2017-06-01 01:35:00]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4c218107068b3358f3c65c729b41...