Revert of [TSAN] Fix TSAN error in i18n RTL.

Revert of [TSAN] Fix TSAN error in i18n RTL. (patchset #3 id:40001 of https://codereview.chromium.org/2877983004/ )

Reason for revert:
Appears to break the Force UI Direction / Force Text Direction / FOrce RTL flags on mac.

BUG=727229
Original issue's description:
> [TSAN] Fix TSAN error in i18n RTL.
> 
> Use an atomic to protect the global g_icu_text_direction cached value
> from multiple readers/writers.
> 
> Also reduce acccess to g_icu_text_diretion so it only has a single write
> location (in SetICUDefaultLocal) and a single read location (ICUIsRTL),
> to simplify the race-y-ness.
> 
> Outside of test code, SetICUDefaultLocal is only used in two locations:
> ppapi_plugin_main.cc and l10n_util.cc, whereas IsRTL is used in >100
> places outside of test code, so it seemed reasonable to move the heavy
> logic (updating g_icu_text_direction when it changes) into what I imagine to be
> a function that is called rarely and let the one that is used a lot
> (IsRTL/ICUIsRTL) just do a simple read.
> 
> This still still leaves a race condition in that IsRTL may give in
> inaccurate result if SetICUDefaultLocale is executed at the same time.
> In particular, IsRTL may return the value for the previously set default
> locale after the default locale has been updated.
> 
> BUG=695929
> TEST=cast_shell_browsertests under TSAN before/after
> 
> Review-Url: https://codereview.chromium.org/2877983004
> Cr-Commit-Position: refs/heads/master@{#472890}
> Committed: https://chromium.googlesource.com/chromium/src/+/89c24d4a46c1f0e7ad03891a659e6d23dc776c36

TBR=jshin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=695929
Review-Url: https://codereview.chromium.org/2917523002
Cr-Commit-Position: refs/heads/master@{#477064}
Committed: https://chromium.googlesource.com/chromium/src/+/27175dace3576a3e351348cf8272c20b0d3aceec

[mbjorge, 2017-05-31 00:55:43]

Created Revert of [TSAN] Fix TSAN error in i18n RTL.

[mbjorge, 2017-05-31 00:58:19]

I don't have a good mac setup to test with, but since I got rid of the path that
sets g_icu_text_direction in IsRTL, I think that is probably what's causing the
issue. I'm guessing that SetICUDefaultLocale is not getting called and
g_icu_text_direction is just not getting set on mac, since SetICUDefaultLocale
checks the forcing command line flags as the first thing, so if it was getting
called I'm believe the text direction would be getting set correctly

[mbjorge, 2017-05-31 00:59:14]

The CQ bit was checked by mbjorge@chromium.org

[commit-bot: I haz the power, 2017-05-31 01:00:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 01:00:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 01:00:16]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[mbjorge, 2017-05-31 16:57:02]

ping, need a committer +1 on this despite TBR to run through CQ

[mbjorge, 2017-06-05 16:31:19]

mbjorge@chromium.org changed reviewers:
+ danakj@chromium.org, dcheng@chromium.org

[mbjorge, 2017-06-05 16:31:19]

+some more base OWNERS for a +1

[dcheng, 2017-06-05 18:24:40]

LGTM

[mbjorge, 2017-06-05 18:31:29]

The CQ bit was checked by mbjorge@chromium.org

[commit-bot: I haz the power, 2017-06-05 18:31:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 20:13:01]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496687489733090, "parent_rev":
"958a6ec35d7013b86aec0a7500547aff25eb8c4b", "commit_rev":
"27175dace3576a3e351348cf8272c20b0d3aceec"}

[commit-bot: I haz the power, 2017-06-05 20:13:16]

Description was changed from

==========
Revert of [TSAN] Fix TSAN error in i18n RTL. (patchset #3 id:40001 of
https://codereview.chromium.org/2877983004/ )

Reason for revert:
Appears to break the Force UI Direction / Force Text Direction / FOrce RTL flags
on mac.

BUG=727229

Original issue's description:
> [TSAN] Fix TSAN error in i18n RTL.
> 
> Use an atomic to protect the global g_icu_text_direction cached value
> from multiple readers/writers.
> 
> Also reduce acccess to g_icu_text_diretion so it only has a single write
> location (in SetICUDefaultLocal) and a single read location (ICUIsRTL),
> to simplify the race-y-ness.
> 
> Outside of test code, SetICUDefaultLocal is only used in two locations:
> ppapi_plugin_main.cc and l10n_util.cc, whereas IsRTL is used in >100
> places outside of test code, so it seemed reasonable to move the heavy
> logic (updating g_icu_text_direction when it changes) into what I imagine to
be
> a function that is called rarely and let the one that is used a lot
> (IsRTL/ICUIsRTL) just do a simple read.
> 
> This still still leaves a race condition in that IsRTL may give in
> inaccurate result if SetICUDefaultLocale is executed at the same time.
> In particular, IsRTL may return the value for the previously set default
> locale after the default locale has been updated.
> 
> BUG=695929
> TEST=cast_shell_browsertests under TSAN before/after
> 
> Review-Url: https://codereview.chromium.org/2877983004
> Cr-Commit-Position: refs/heads/master@{#472890}
> Committed:
https://chromium.googlesource.com/chromium/src/+/89c24d4a46c1f0e7ad03891a659e...

TBR=jshin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=695929
==========

to

==========
Revert of [TSAN] Fix TSAN error in i18n RTL. (patchset #3 id:40001 of
https://codereview.chromium.org/2877983004/ )

Reason for revert:
Appears to break the Force UI Direction / Force Text Direction / FOrce RTL flags
on mac.

BUG=727229

Original issue's description:
> [TSAN] Fix TSAN error in i18n RTL.
> 
> Use an atomic to protect the global g_icu_text_direction cached value
> from multiple readers/writers.
> 
> Also reduce acccess to g_icu_text_diretion so it only has a single write
> location (in SetICUDefaultLocal) and a single read location (ICUIsRTL),
> to simplify the race-y-ness.
> 
> Outside of test code, SetICUDefaultLocal is only used in two locations:
> ppapi_plugin_main.cc and l10n_util.cc, whereas IsRTL is used in >100
> places outside of test code, so it seemed reasonable to move the heavy
> logic (updating g_icu_text_direction when it changes) into what I imagine to
be
> a function that is called rarely and let the one that is used a lot
> (IsRTL/ICUIsRTL) just do a simple read.
> 
> This still still leaves a race condition in that IsRTL may give in
> inaccurate result if SetICUDefaultLocale is executed at the same time.
> In particular, IsRTL may return the value for the previously set default
> locale after the default locale has been updated.
> 
> BUG=695929
> TEST=cast_shell_browsertests under TSAN before/after
> 
> Review-Url: https://codereview.chromium.org/2877983004
> Cr-Commit-Position: refs/heads/master@{#472890}
> Committed:
https://chromium.googlesource.com/chromium/src/+/89c24d4a46c1f0e7ad03891a659e...

TBR=jshin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=695929

Review-Url: https://codereview.chromium.org/2917523002
Cr-Commit-Position: refs/heads/master@{#477064}
Committed:
https://chromium.googlesource.com/chromium/src/+/27175dace3576a3e351348cf8272...
==========

[commit-bot: I haz the power, 2017-06-05 20:13:17]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/27175dace3576a3e351348cf8272...