Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2917463002: Enable vp09 codec string in WebM by default (Closed)

Created:
3 years, 6 months ago by chcunningham
Modified:
3 years, 6 months ago
CC:
chfremer+watch_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, ddorwin, feature-media-reviews_chromium.org, jam, kqyang, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable vp09 codec string in WebM by default Removes need for command line switch --enable-new-vp9-codec-string BUG=727902 Review-Url: https://codereview.chromium.org/2917463002 Cr-Commit-Position: refs/heads/master@{#477749} Committed: https://chromium.googlesource.com/chromium/src/+/6d43fc8beaa41811acc6c77a56ab2174ca283788

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update support/tests for high bit depth profiles. #

Patch Set 3 : Little test/compiling fixes #

Patch Set 4 : Rebase (depends-on patch landed), browser_test tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -137 lines) Patch
M chrome/browser/media/encrypted_media_supported_types_browsertest.cc View 1 2 3 10 chunks +26 lines, -8 lines 0 comments Download
M content/browser/media/media_canplaytype_browsertest.cc View 1 2 3 2 chunks +35 lines, -62 lines 0 comments Download
M content/browser/media/media_capabilities_browsertest.cc View 2 3 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M media/base/decode_capabilities.cc View 1 2 3 chunks +34 lines, -2 lines 0 comments Download
M media/base/media.h View 1 chunk +0 lines, -7 lines 0 comments Download
M media/base/media.cc View 3 chunks +0 lines, -22 lines 0 comments Download
M media/base/media_switches.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M media/base/media_switches.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M media/base/mime_util_internal.cc View 1 2 3 2 chunks +7 lines, -6 lines 0 comments Download
M media/base/mime_util_unittest.cc View 3 chunks +0 lines, -17 lines 0 comments Download

Messages

Total messages: 35 (23 generated)
chcunningham
Removes all mention of the command line argument. Updates tests to expect support by default. ...
3 years, 6 months ago (2017-05-30 21:52:34 UTC) #4
chcunningham
3 years, 6 months ago (2017-06-01 20:44:36 UTC) #6
chcunningham
Hey Dale. Looks like we have all the LGTMs to ship. PTAL
3 years, 6 months ago (2017-06-02 18:02:10 UTC) #7
DaleCurtis
lgtm % q https://codereview.chromium.org/2917463002/diff/1/content/browser/media/media_canplaytype_browsertest.cc File content/browser/media/media_canplaytype_browsertest.cc (right): https://codereview.chromium.org/2917463002/diff/1/content/browser/media/media_canplaytype_browsertest.cc#newcode1517 content/browser/media/media_canplaytype_browsertest.cc:1517: // TODO(chcunningham): Plumb proper querying of ...
3 years, 6 months ago (2017-06-02 18:58:38 UTC) #8
chcunningham
+xhwang for EME and vp09 test changes. https://codereview.chromium.org/2917463002/diff/1/content/browser/media/media_canplaytype_browsertest.cc File content/browser/media/media_canplaytype_browsertest.cc (right): https://codereview.chromium.org/2917463002/diff/1/content/browser/media/media_canplaytype_browsertest.cc#newcode1517 content/browser/media/media_canplaytype_browsertest.cc:1517: // TODO(chcunningham): ...
3 years, 6 months ago (2017-06-06 02:46:40 UTC) #10
chcunningham
FYI - this patch is still built on top of (includes) https://chromium-review.googlesource.com/c/511165/. That should land ...
3 years, 6 months ago (2017-06-06 02:52:23 UTC) #13
xhwang
eme lgtm
3 years, 6 months ago (2017-06-06 04:55:22 UTC) #16
chcunningham
+creis for content.
3 years, 6 months ago (2017-06-06 21:33:23 UTC) #25
Charlie Reis
content/ LGTM
3 years, 6 months ago (2017-06-06 22:43:45 UTC) #26
DaleCurtis
lgtm
3 years, 6 months ago (2017-06-07 18:21:09 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2917463002/80001
3 years, 6 months ago (2017-06-07 20:14:21 UTC) #32
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 20:22:31 UTC) #35
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/6d43fc8beaa41811acc6c77a56ab...

Powered by Google App Engine
This is Rietveld 408576698