Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2917393002: VR: Hide 2D screenshot when resuming activities in VR and hide 2D UI while loading VR UI. (Closed)

Created:
3 years, 6 months ago by mthiesse
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

VR: Hide 2D screenshot when resuming activities in VR and hide 2D UI while loading VR UI. This CL adds an animation that keeps the resuming Activity hidden for 500ms while starting up to allow time for us to draw the black overlay, also added in this CL, and prevent 2D UI from being shown while entering VR. This also performs some cleanup around VR entry (now that it's even more async than before) to ensure that we don't continue trying to enter VR after we try to exit VR (like when the activity is paused, etc.). Bug: 728148 Change-Id: I344ad661b632bde74764b134e9d9f70f6258d68d Reviewed-on: https://chromium-review.googlesource.com/519483 Reviewed-by: David Trainor <dtrainor@chromium.org>; Reviewed-by: Yash Malik <ymalik@chromium.org>; Commit-Queue: Michael Thiessen <mthiesse@chromium.org>; Cr-Original-Commit-Position: refs/heads/master@{#476301} Review-Url: https://codereview.chromium.org/2917393002 . Cr-Commit-Position: refs/branch-heads/3112@{#148} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/1d2c3e91d531a0565726650dbccceacc39dfb8a7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -11 lines) Patch
A chrome/android/java/res/anim/stay_hidden.xml View 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/android/java/res/values-v17/styles.xml View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java View 16 chunks +92 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
mthiesse
3 years, 6 months ago (2017-06-05 14:23:00 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1d2c3e91d531a0565726650dbccceacc39dfb8a7.

Powered by Google App Engine
This is Rietveld 408576698