Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2917363004: Add test for ReadingListMediator (Closed)

Created:
3 years, 6 months ago by gambard
Modified:
3 years, 6 months ago
Reviewers:
jif
CC:
chromium-reviews, marq+watch_chromium.org, stkhapugin, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add test for ReadingListMediator Test ReadingListMediator for filling read and unread array. BUG=721758 Review-Url: https://codereview.chromium.org/2917363004 Cr-Commit-Position: refs/heads/master@{#477341} Committed: https://chromium.googlesource.com/chromium/src/+/0ff947cea6682a0cc4b8e7578b4d43534140e843

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -0 lines) Patch
M ios/chrome/browser/ui/reading_list/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/reading_list/reading_list_mediator_unittest.mm View 1 chunk +74 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
gambard
PTAL, I forgot the test in the previous CL :(
3 years, 6 months ago (2017-06-06 15:22:18 UTC) #2
jif
lgtm
3 years, 6 months ago (2017-06-06 16:39:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2917363004/1
3 years, 6 months ago (2017-06-06 16:40:20 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 18:07:24 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0ff947cea6682a0cc4b8e7578b4d...

Powered by Google App Engine
This is Rietveld 408576698