Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2917353004: VR: Don't unregister Daydream intent when leaving webVR page if browsing is supported. (Closed)

Created:
3 years, 6 months ago by mthiesse
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

VR: Don't unregister Daydream intent when leaving webVR page if browsing is supported. If we support browsing in VR, when we leave a page that support presentation on headset insertion, don't unregister the Daydream intent. Bug: 728638 Change-Id: Ie9087e2a2a35a6e5d5839b6f1ef0672ba3b781aa Reviewed-on: https://chromium-review.googlesource.com/521942 Reviewed-by: Yash Malik <ymalik@chromium.org>; Commit-Queue: Michael Thiessen <mthiesse@chromium.org>; Cr-Original-Commit-Position: refs/heads/master@{#476459} Review-Url: https://codereview.chromium.org/2917353004 . Cr-Commit-Position: refs/branch-heads/3112@{#147} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/565e96bdfad900f9adb3232e147288b67b378f0c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
mthiesse
3 years, 6 months ago (2017-06-05 14:19:47 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
565e96bdfad900f9adb3232e147288b67b378f0c.

Powered by Google App Engine
This is Rietveld 408576698