Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(851)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

Issue 2917343003: Merge-60 [Payments] Move the SelectedPaymentMethod metric to native. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
index fbfd05f4de4317945a5d98927ec8d9691b3adfc2..f1f04590ac619e095e3d3b777f79228c16eb217c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
@@ -1627,15 +1627,12 @@ public class PaymentRequestImpl implements PaymentRequest, PaymentRequestUI.Clie
PersonalDataManager.getInstance().recordAndLogCreditCardUse(
selectedPaymentMethod.getIdentifier());
}
- PaymentRequestMetrics.recordSelectedPaymentMethodHistogram(
- SelectedPaymentMethod.CREDIT_CARD);
+ mJourneyLogger.setSelectedPaymentMethod(SelectedPaymentMethod.CREDIT_CARD);
} else if (methodName.equals(ANDROID_PAY_METHOD_NAME)
|| methodName.equals(PAY_WITH_GOOGLE_METHOD_NAME)) {
- PaymentRequestMetrics.recordSelectedPaymentMethodHistogram(
- SelectedPaymentMethod.ANDROID_PAY);
+ mJourneyLogger.setSelectedPaymentMethod(SelectedPaymentMethod.ANDROID_PAY);
} else {
- PaymentRequestMetrics.recordSelectedPaymentMethodHistogram(
- SelectedPaymentMethod.OTHER_PAYMENT_APP);
+ mJourneyLogger.setSelectedPaymentMethod(SelectedPaymentMethod.OTHER_PAYMENT_APP);
}
// Showing the payment request UI if we were previously skipping it so the loading

Powered by Google App Engine
This is Rietveld 408576698