Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3092)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/JourneyLogger.java

Issue 2917343003: Merge-60 [Payments] Move the SelectedPaymentMethod metric to native. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/payments/JourneyLogger.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/JourneyLogger.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/JourneyLogger.java
index 35718d7e30135b4d64fcdc6b1304481ef6cd4b8d..878f853f399cbc2842facfd84c4b0699330ca96d 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/JourneyLogger.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/JourneyLogger.java
@@ -93,12 +93,26 @@ public class JourneyLogger {
/**
* Records that an event occurred.
+ *
+ * @param event The event that occured.
*/
public void setEventOccurred(int event) {
+ assert event >= 0;
assert event < Event.ENUM_MAX;
nativeSetEventOccurred(mJourneyLoggerAndroid, event);
}
+ /**
+ * Records the payment method that was selected by the user.
+ *
+ * @param paymentMethod The payment method that was selected.
+ */
+ public void setSelectedPaymentMethod(int paymentMethod) {
+ assert paymentMethod >= 0;
+ assert paymentMethod < SelectedPaymentMethod.MAX;
+ nativeSetSelectedPaymentMethod(mJourneyLoggerAndroid, paymentMethod);
+ }
+
/**
* Records that the Payment Request was completed sucessfully. Also starts the logging of
* all the journey logger metrics.
@@ -159,6 +173,8 @@ public class JourneyLogger {
long nativeJourneyLoggerAndroid, boolean value);
private native void nativeSetShowCalled(long nativeJourneyLoggerAndroid);
private native void nativeSetEventOccurred(long nativeJourneyLoggerAndroid, int event);
+ private native void nativeSetSelectedPaymentMethod(
+ long nativeJourneyLoggerAndroid, int paymentMethod);
private native void nativeSetCompleted(long nativeJourneyLoggerAndroid);
private native void nativeSetAborted(long nativeJourneyLoggerAndroid, int reason);
private native void nativeSetNotShown(long nativeJourneyLoggerAndroid, int reason);
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698