Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2917343002: Run PermissionRequestManager tests on Android (Closed)

Created:
3 years, 6 months ago by Timothy Loh
Modified:
3 years, 6 months ago
Reviewers:
raymes
CC:
chromium-reviews, mlamouri+watch-permissions_chromium.org, raymes+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Run PermissionRequestManager tests on Android BUG=606138 Review-Url: https://codereview.chromium.org/2917343002 Cr-Commit-Position: refs/heads/master@{#477173} Committed: https://chromium.googlesource.com/chromium/src/+/f0a98781eb42e7828ff9d3e759f4e5894ab8805f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M chrome/browser/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/permissions/mock_permission_request.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/permissions/mock_permission_request.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
Timothy Loh
3 years, 6 months ago (2017-06-05 04:13:00 UTC) #4
raymes
lgtm
3 years, 6 months ago (2017-06-06 03:17:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2917343002/1
3 years, 6 months ago (2017-06-06 03:19:45 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 03:24:12 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f0a98781eb42e7828ff9d3e759f4...

Powered by Google App Engine
This is Rietveld 408576698