Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2917313002: Page load metrics: clarify who can review what (Closed)

Created:
3 years, 6 months ago by kinuko
Modified:
3 years, 6 months ago
CC:
chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org, speed-metrics-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Page load metrics: clarify who can review what BUG=n/a R=bmcquade@chromium.org,csharrison@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2917313002 Cr-Commit-Position: refs/heads/master@{#477133} Committed: https://chromium.googlesource.com/chromium/src/+/6f7a4d0d7fbc3bae5e93fb52f69ae4e0bceb34c6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/page_load_metrics/OWNERS View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
kinuko
What do you think?
3 years, 6 months ago (2017-06-05 03:53:16 UTC) #2
Bryan McQuade
LGTM, thank you!
3 years, 6 months ago (2017-06-05 14:11:11 UTC) #3
Charlie Harrison
lgtm/2
3 years, 6 months ago (2017-06-05 14:12:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2917313002/1
3 years, 6 months ago (2017-06-06 00:33:10 UTC) #6
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 00:38:57 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6f7a4d0d7fbc3bae5e93fb52f69a...

Powered by Google App Engine
This is Rietveld 408576698