Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2917213003: [Payments] Record SelectedPaymentMethod metric on Desktop. (Closed)

Created:
3 years, 6 months ago by sebsg
Modified:
3 years, 6 months ago
Reviewers:
Mathieu
CC:
chromium-reviews, tfarina, jam, gogerald+paymentswatch_chromium.org, rouslan+payments_chromium.org, darin-cc_chromium.org, mahmadi+paymentswatch_chromium.org, sebsg+paymentswatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payments] Record SelectedPaymentMethod metric on Desktop. BUG=729349 Review-Url: https://codereview.chromium.org/2917213003 Cr-Commit-Position: refs/heads/master@{#476984} Committed: https://chromium.googlesource.com/chromium/src/+/ec8296f9e18e289b845bf3fba29143964a8a35f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -0 lines) Patch
A chrome/browser/ui/views/payments/payment_request_journey_logger_browsertest.cc View 1 chunk +52 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/payments/content/payment_request.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
sebsg
Hi Math, PTAL?
3 years, 6 months ago (2017-06-03 20:53:10 UTC) #5
Mathieu
lgtm
3 years, 6 months ago (2017-06-05 13:26:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2917213003/20001
3 years, 6 months ago (2017-06-05 13:26:49 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-05 15:14:43 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ec8296f9e18e289b845bf3fba291...

Powered by Google App Engine
This is Rietveld 408576698