Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 2917203002: Add MuteableAudioOutputStream interface to export SetMute(). (Closed)

Created:
3 years, 6 months ago by AndyWu
Modified:
3 years, 6 months ago
CC:
avayvod+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org, mlamouri+watch-media_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add MuteableAudioOutputStream interface to export SetMute(). This CL is part of enabling (E)AC3 passthrough feature. Will create AudioTrack output stream to handle compressed bitstream formats, so AudioManagerAndroid should not dependent on the additional function of OpenSLESOutputStream. Instead, create a new interface, MuteableAudioOutputStream, to export the additional function, SetMute(). BUG=613385 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2917203002 Cr-Commit-Position: refs/heads/master@{#477125} Committed: https://chromium.googlesource.com/chromium/src/+/8895ae553eb9985057a3124ae25ffd756413983e

Patch Set 1 #

Patch Set 2 : Bug fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -12 lines) Patch
M media/audio/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M media/audio/android/audio_manager_android.h View 3 chunks +6 lines, -2 lines 0 comments Download
M media/audio/android/audio_manager_android.cc View 1 3 chunks +11 lines, -2 lines 0 comments Download
A media/audio/android/muteable_audio_output_stream.h View 1 chunk +23 lines, -0 lines 0 comments Download
M media/audio/android/opensles_output.h View 4 chunks +4 lines, -4 lines 0 comments Download
M media/audio/audio_manager_base.h View 1 chunk +6 lines, -0 lines 0 comments Download
M media/audio/audio_manager_base.cc View 3 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
AndyWu
3 years, 6 months ago (2017-06-02 22:28:24 UTC) #4
DaleCurtis
lgtm
3 years, 6 months ago (2017-06-02 22:35:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2917203002/20001
3 years, 6 months ago (2017-06-05 19:19:40 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-05 23:51:15 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8895ae553eb9985057a3124ae25f...

Powered by Google App Engine
This is Rietveld 408576698