Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 2917193002: [ObjC ARC] Converts ios/chrome/browser/memory:memory to ARC. (Closed)

Created:
3 years, 6 months ago by pkl (ping after 24h if needed)
Modified:
3 years, 6 months ago
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/memory:memory to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2917193002 Cr-Commit-Position: refs/heads/master@{#480807} Committed: https://chromium.googlesource.com/chromium/src/+/5b25f6754fddeb03947dbfbe8dfa2e525723c0bc

Patch Set 1 #

Patch Set 2 : weak-ify #

Total comments: 2

Patch Set 3 : Use __weak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -50 lines) Patch
M ios/chrome/browser/memory/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/memory/memory_debugger.mm View 13 chunks +37 lines, -39 lines 0 comments Download
M ios/chrome/browser/memory/memory_debugger_manager.mm View 1 2 5 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
pkl (ping after 24h if needed)
stk: ARC Conversion rohitrao: OWNERS review. Thanks!
3 years, 6 months ago (2017-06-02 21:43:56 UTC) #4
rohitrao (ping after 24h)
lgtm but please wait for stk
3 years, 6 months ago (2017-06-05 14:27:28 UTC) #5
pkl (ping after 24h if needed)
stk:ping
3 years, 6 months ago (2017-06-07 05:05:27 UTC) #6
sdefresne
On 2017/06/07 05:05:27, pkl -pls.ping.after.24h. wrote: > stk:ping stk is OOO for the week.
3 years, 6 months ago (2017-06-07 08:46:50 UTC) #7
stkhapugin
lgtm https://codereview.chromium.org/2917193002/diff/20001/ios/chrome/browser/memory/memory_debugger_manager.mm File ios/chrome/browser/memory/memory_debugger_manager.mm (right): https://codereview.chromium.org/2917193002/diff/20001/ios/chrome/browser/memory/memory_debugger_manager.mm#newcode19 ios/chrome/browser/memory/memory_debugger_manager.mm:19: __unsafe_unretained UIView* debuggerParentView_; // weak This should become ...
3 years, 6 months ago (2017-06-12 12:21:11 UTC) #8
pkl (ping after 24h if needed)
https://codereview.chromium.org/2917193002/diff/20001/ios/chrome/browser/memory/memory_debugger_manager.mm File ios/chrome/browser/memory/memory_debugger_manager.mm (right): https://codereview.chromium.org/2917193002/diff/20001/ios/chrome/browser/memory/memory_debugger_manager.mm#newcode19 ios/chrome/browser/memory/memory_debugger_manager.mm:19: __unsafe_unretained UIView* debuggerParentView_; // weak On 2017/06/12 12:21:10, stkhapugin ...
3 years, 6 months ago (2017-06-20 12:18:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2917193002/40001
3 years, 6 months ago (2017-06-20 12:20:11 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 14:14:23 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5b25f6754fddeb03947dbfbe8dfa...

Powered by Google App Engine
This is Rietveld 408576698