pkg/analyzer_cli/lib/src/analyzer_impl.dart - Issue 2917183003: update the analyzer and analysis server perf tags

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer_cli/lib/src/analyzer_impl.dart

Issue 2917183003: update the analyzer and analysis server perf tags (Closed)

Patch Set: updates for review comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer_cli/lib/src/analyzer_impl.dart

diff --git a/pkg/analyzer_cli/lib/src/analyzer_impl.dart b/pkg/analyzer_cli/lib/src/analyzer_impl.dart

index d9ea1ab350e83dbaaf638bc49685363f89985981..d3734fd573328d523c350dd38690576cbf8bc987 100644

--- a/pkg/analyzer_cli/lib/src/analyzer_impl.dart

+++ b/pkg/analyzer_cli/lib/src/analyzer_impl.dart

@@ -227,7 +227,7 @@ class AnalyzerImpl {

int totalTime = currentTimeMillis - startTime;

int otherTime = totalTime;

for (PerformanceTag tag in PerformanceTag.all) {

- if (tag != PerformanceTag.UNKNOWN) {

+ if (tag != PerformanceTag.unknown) {

int tagTime = tag.elapsedMs;

outSink.writeln('${tag.label}-cold:$tagTime');

otherTime -= tagTime;