Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1004)

Side by Side Diff: pkg/analyzer_cli/lib/src/analyzer_impl.dart

Issue 2917183003: update the analyzer and analysis server perf tags (Closed)
Patch Set: updates for review comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library analyzer_cli.src.analyzer_impl; 5 library analyzer_cli.src.analyzer_impl;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'dart:collection'; 8 import 'dart:collection';
9 import 'dart:io'; 9 import 'dart:io';
10 10
(...skipping 209 matching lines...) Expand 10 before | Expand all | Expand 10 after
220 return packageName.startsWith(options.showPackageWarningsPrefix); 220 return packageName.startsWith(options.showPackageWarningsPrefix);
221 } 221 }
222 } 222 }
223 223
224 // TODO(devoncarew): This is never called. 224 // TODO(devoncarew): This is never called.
225 void _printColdPerf() { 225 void _printColdPerf() {
226 // Print cold VM performance numbers. 226 // Print cold VM performance numbers.
227 int totalTime = currentTimeMillis - startTime; 227 int totalTime = currentTimeMillis - startTime;
228 int otherTime = totalTime; 228 int otherTime = totalTime;
229 for (PerformanceTag tag in PerformanceTag.all) { 229 for (PerformanceTag tag in PerformanceTag.all) {
230 if (tag != PerformanceTag.UNKNOWN) { 230 if (tag != PerformanceTag.unknown) {
231 int tagTime = tag.elapsedMs; 231 int tagTime = tag.elapsedMs;
232 outSink.writeln('${tag.label}-cold:$tagTime'); 232 outSink.writeln('${tag.label}-cold:$tagTime');
233 otherTime -= tagTime; 233 otherTime -= tagTime;
234 } 234 }
235 } 235 }
236 outSink.writeln('other-cold:$otherTime'); 236 outSink.writeln('other-cold:$otherTime');
237 outSink.writeln("total-cold:$totalTime"); 237 outSink.writeln("total-cold:$totalTime");
238 } 238 }
239 239
240 ErrorSeverity _defaultSeverityProcessor(AnalysisError error) => 240 ErrorSeverity _defaultSeverityProcessor(AnalysisError error) =>
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
303 } 303 }
304 304
305 @override 305 @override
306 void logInformation(String message, [CaughtException exception]) { 306 void logInformation(String message, [CaughtException exception]) {
307 outSink.writeln(message); 307 outSink.writeln(message);
308 if (exception != null) { 308 if (exception != null) {
309 outSink.writeln(exception); 309 outSink.writeln(exception);
310 } 310 }
311 } 311 }
312 } 312 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698