Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: pkg/analyzer/lib/source/pub_package_map_provider.dart

Issue 2917183003: update the analyzer and analysis server perf tags (Closed)
Patch Set: updates for review comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/status/diagnostics.dart ('k') | pkg/analyzer/lib/src/context/context.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/source/pub_package_map_provider.dart
diff --git a/pkg/analyzer/lib/source/pub_package_map_provider.dart b/pkg/analyzer/lib/source/pub_package_map_provider.dart
index 3b2d7311f5c4ac66bcf54d7391585b8c7cf95977..2196d1c8720b9a9e9129daee4558128abf569ae2 100644
--- a/pkg/analyzer/lib/source/pub_package_map_provider.dart
+++ b/pkg/analyzer/lib/source/pub_package_map_provider.dart
@@ -9,6 +9,7 @@ import 'dart:convert';
import 'dart:core';
import 'dart:io' as io;
+import 'package:analysis_server/src/analysis_server.dart';
Paul Berry 2017/06/05 12:42:33 A file in package:analyzer can't import a file fro
devoncarew 2017/06/05 13:35:45 Thanks for the heads up! Yes, it would be possible
import 'package:analyzer/file_system/file_system.dart';
import 'package:analyzer/source/package_map_provider.dart';
import 'package:analyzer/src/dart/sdk/sdk.dart';
@@ -71,7 +72,9 @@ class PubPackageMapProvider implements PackageMapProvider {
// to respond.
io.ProcessResult result;
try {
- result = _runPubList(folder);
+ result = ServerPerformanceStatistics.pub.makeCurrentWhile(() {
+ return _runPubList(folder);
+ });
} on io.ProcessException catch (exception, stackTrace) {
AnalysisEngine.instance.logger.logInformation(
"Error running pub $PUB_LIST_COMMAND\n$exception\n$stackTrace");
« no previous file with comments | « pkg/analysis_server/lib/src/status/diagnostics.dart ('k') | pkg/analyzer/lib/src/context/context.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698