Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1086)

Unified Diff: pkg/analysis_server/lib/src/status/diagnostics.dart

Issue 2917183003: update the analyzer and analysis server perf tags (Closed)
Patch Set: updates for review comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/status/diagnostics.dart
diff --git a/pkg/analysis_server/lib/src/status/diagnostics.dart b/pkg/analysis_server/lib/src/status/diagnostics.dart
index 93c38047fd19844e6e385edff62a39b6c3fc218d..1208b42392d4a674d861382f4fb124a9b36bdad0 100644
--- a/pkg/analysis_server/lib/src/status/diagnostics.dart
+++ b/pkg/analysis_server/lib/src/status/diagnostics.dart
@@ -39,7 +39,7 @@ final String kCustomCss = '''
.container {
width: 1160px;
}
-
+
.masthead {
padding-top: 1rem;
padding-bottom: 1rem;
@@ -93,8 +93,8 @@ final String kCustomCss = '''
.menu-item .counter {
float: right;
margin-left: 5px;
-}
-
+}
+
td.right {
text-align: right;
}
@@ -239,7 +239,7 @@ abstract class DiagnosticPage extends Page {
buf.writeln('''
<footer class="footer">
Dart ${site.title} <span style="float:right">SDK ${_sdkVersion}</span>
- </footer>
+ </footer>
''');
}
@@ -432,7 +432,8 @@ class ProfilePage extends DiagnosticPageWithNav {
// prepare sorted tags
List<PerformanceTag> tags = PerformanceTag.all.toList();
tags.remove(ServerPerformanceStatistics.idle);
- tags.remove(PerformanceTag.UNKNOWN);
+ tags.remove(PerformanceTag.unknown);
+ tags.removeWhere((tag) => tag.elapsedMs == 0);
tags.sort((a, b) => b.elapsedMs - a.elapsedMs);
// draw a pie chart
@@ -444,7 +445,7 @@ class ProfilePage extends DiagnosticPageWithNav {
<script type="text/javascript">
google.charts.load('current', {'packages':['corechart']});
google.charts.setOnLoadCallback(drawChart);
-
+
function drawChart() {
var data = new google.visualization.DataTable();
data.addColumn('string', 'Tag');
@@ -454,7 +455,7 @@ class ProfilePage extends DiagnosticPageWithNav {
var chart = new google.visualization.PieChart(document.getElementById('chart-div'));
chart.draw(data, options);
}
- </script>
+ </script>
''');
// print total time
@@ -849,7 +850,7 @@ class CompletionPage extends DiagnosticPageWithNav {
var chart = new google.charts.Bar(document.getElementById('chart-div'));
chart.draw(data, google.charts.Bar.convertOptions(options));
}
- </script>
+ </script>
''');
// emit the data as a table

Powered by Google App Engine
This is Rietveld 408576698