Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 2917183002: Renaming SearchAnswerWebContentsDelegate. (Closed)

Created:
3 years, 6 months ago by vadimt
Modified:
3 years, 6 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, tfarina, Matt Giuca
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Renaming SearchAnswerWebContentsDelegate. Renamed to AnswerCardSearchProvider. Bug=712331 Review-Url: https://codereview.chromium.org/2917183002 Cr-Commit-Position: refs/heads/master@{#476869} Committed: https://chromium.googlesource.com/chromium/src/+/089996867fb18c8e7275fef9b4ced99e19d8acac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -468 lines) Patch
M chrome/browser/ui/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/app_list/search/answer_card_search_provider.h View 2 chunks +6 lines, -7 lines 0 comments Download
A + chrome/browser/ui/app_list/search/answer_card_search_provider.cc View 11 chunks +16 lines, -16 lines 0 comments Download
M chrome/browser/ui/app_list/search/search_controller_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/ui/app_list/search_answer_web_contents_delegate.h View 1 chunk +0 lines, -115 lines 0 comments Download
D chrome/browser/ui/app_list/search_answer_web_contents_delegate.cc View 1 chunk +0 lines, -326 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
vadimt
3 years, 6 months ago (2017-06-02 21:18:42 UTC) #2
xiyuan
lgtm
3 years, 6 months ago (2017-06-02 21:49:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2917183002/1
3 years, 6 months ago (2017-06-02 23:28:19 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/442311)
3 years, 6 months ago (2017-06-03 01:43:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2917183002/1
3 years, 6 months ago (2017-06-03 01:45:33 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-03 02:39:10 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/089996867fb18c8e7275fef9b4ce...

Powered by Google App Engine
This is Rietveld 408576698