Make PopupMenuTest wait for RenderWidgetHostView initialization

Make PopupMenuTest wait for RenderWidgetHostView initialization

SitePerProcessBrowserTest.PopupMenuTest has been observed to have
occasional flakes, and the cause seems to be a race between handlers
of ViewMsg_ShowWidget messages. The test code uses a message filter
which notifies upon receipt of ShowWidget, and WebContentsImpl is the
ultimate recipient of that message which causes it to initialize the
popup widget.

Occasionally the test code will run before WebContentsImpl's handler
has fired, in which case the RenderWidgetHostView has not been
initialized, resulting in a crash. This CL adds a loop to wait for
initialization to be completed before proceeding with the test.

BUG=723657
Review-Url: https://codereview.chromium.org/2917173002
Cr-Commit-Position: refs/heads/master@{#476839}
Committed: https://chromium.googlesource.com/chromium/src/+/37003a1722d89acc689cd3911efceb583bad43e0

[kenrb, 2017-06-02 21:09:24]

The CQ bit was checked by kenrb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 21:10:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kenrb, 2017-06-02 21:11:33]

kenrb@chromium.org changed reviewers:
+ nasko@chromium.org

[kenrb, 2017-06-02 21:11:34]

nasko: PTAL?

[nasko, 2017-06-02 23:57:57]

LGTM

[nasko, 2017-06-03 00:00:26]

The CQ bit was unchecked by nasko@chromium.org

[nasko, 2017-06-03 00:00:36]

The CQ bit was checked by nasko@chromium.org

[commit-bot: I haz the power, 2017-06-03 00:01:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-03 00:17:06]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496448036073140, "parent_rev":
"177b9b934d8398dfb0d17b88fd9ff00f3291cca5", "commit_rev":
"37003a1722d89acc689cd3911efceb583bad43e0"}

[commit-bot: I haz the power, 2017-06-03 00:17:20]

Description was changed from

==========
Make PopupMenuTest wait for RenderWidgetHostView initialization

SitePerProcessBrowserTest.PopupMenuTest has been observed to have
occasional flakes, and the cause seems to be a race between handlers
of ViewMsg_ShowWidget messages. The test code uses a message filter
which notifies upon receipt of ShowWidget, and WebContentsImpl is the
ultimate recipient of that message which causes it to initialize the
popup widget.

Occasionally the test code will run before WebContentsImpl's handler
has fired, in which case the RenderWidgetHostView has not been
initialized, resulting in a crash. This CL adds a loop to wait for
initialization to be completed before proceeding with the test.

BUG=723657
==========

to

==========
Make PopupMenuTest wait for RenderWidgetHostView initialization

SitePerProcessBrowserTest.PopupMenuTest has been observed to have
occasional flakes, and the cause seems to be a race between handlers
of ViewMsg_ShowWidget messages. The test code uses a message filter
which notifies upon receipt of ShowWidget, and WebContentsImpl is the
ultimate recipient of that message which causes it to initialize the
popup widget.

Occasionally the test code will run before WebContentsImpl's handler
has fired, in which case the RenderWidgetHostView has not been
initialized, resulting in a crash. This CL adds a loop to wait for
initialization to be completed before proceeding with the test.

BUG=723657

Review-Url: https://codereview.chromium.org/2917173002
Cr-Commit-Position: refs/heads/master@{#476839}
Committed:
https://chromium.googlesource.com/chromium/src/+/37003a1722d89acc689cd3911efc...
==========

[commit-bot: I haz the power, 2017-06-03 00:17:21]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/37003a1722d89acc689cd3911efc...