chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js - Issue 2917123002: Support role description in automation/ChromeVox

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

Issue 2917123002: Support role description in automation/ChromeVox (Closed)

Patch Set: Changes to c/c/e/a/PRESUBMIT.py Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/earcon_engine.js ('k') | chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs » ('j') | chrome/common/extensions/api/PRESUBMIT.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

index 2f37148e546341894de9e297c0b66e29040bb99c..8b8d2357784c6809362a3ecf715d12b3730595d1 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

@@ -1243,7 +1243,9 @@ Output.prototype = {

options.annotation.push(token);

var msg = node.role;

var info = Output.ROLE_INFO_[node.role];

- if (info) {

+ if (node.roleDescription) {

+ msg = node.roleDescription;

+ } else if (info) {

if (this.formatOptions_.braille)

msg = Msgs.getMsg(info.msgId + '_brl');

else