Support role description in automation/ChromeVox

Support role description in automation/ChromeVox

Adds support for role description throughout and fixes some errros caught by an upgrade to the Closure compiler. Also fixes an issue caught by updating automation externs.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2917123002
Cr-Commit-Position: refs/heads/master@{#477286}
Committed: https://chromium.googlesource.com/chromium/src/+/5af488e3095f444e1ec680c7b89dfee2c772b35b

[David Tseng, 2017-06-02 18:48:25]

Description was changed from

==========
Support role description in automation/ChromeVox
==========

to

==========
Support role description in automation/ChromeVox
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2017-06-02 18:48:59]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org, michaelpg@chromium.org

[David Tseng, 2017-06-02 18:57:39]

The CQ bit was checked by dtseng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 18:58:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dmazzoni, 2017-06-02 19:55:24]

lgtm

Please update the change description to reflect the other fixes you made

https://codereview.chromium.org/2917123002/diff/1/chrome/browser/resources/ch...
File
chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js
(left):

https://codereview.chromium.org/2917123002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js:281:
Role.DIV,
Why didn't the compile fail when DIV was removed?

Is our presubmit only one-way, i.e. it catches
additions but not deletions?

[David Tseng, 2017-06-02 21:34:05]

Description was changed from

==========
Support role description in automation/ChromeVox
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Support role description in automation/ChromeVox

Adds support for role description throughout and fixes some errros caught by an
upgrade to the Closure compiler. Also fixes an issue caught by updating
automation externs.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2017-06-02 21:34:34]

michaelpg for t/c/e/automation.js

https://codereview.chromium.org/2917123002/diff/1/chrome/browser/resources/ch...
File
chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js
(left):

https://codereview.chromium.org/2917123002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js:281:
Role.DIV,
On 2017/06/02 19:55:24, dmazzoni wrote:
> Why didn't the compile fail when DIV was removed?
> 
> Is our presubmit only one-way, i.e. it catches
> additions but not deletions?

No, it has to do with the externs not being re-generated when you edit an idl
file.
Since it wasn't re-generated, the externs still had the old DIV role...

[commit-bot: I haz the power, 2017-06-02 22:34:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 22:34:59]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[michaelpg, 2017-06-03 00:01:35]

devlin/dan: This whitelisting makes me sad (is it necessary because some externs
are out-of-date or something?)

https://codereview.chromium.org/2917123002/diff/1/chrome/browser/resources/ch...
File
chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js
(left):

https://codereview.chromium.org/2917123002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js:281:
Role.DIV,
On 2017/06/02 21:34:34, David Tseng wrote:
> On 2017/06/02 19:55:24, dmazzoni wrote:
> > Why didn't the compile fail when DIV was removed?
> > 
> > Is our presubmit only one-way, i.e. it catches
> > additions but not deletions?
> 
> No, it has to do with the externs not being re-generated when you edit an idl
> file.
> Since it wasn't re-generated, the externs still had the old DIV role...

Add automation.idl to api_pair_names:
https://cs.chromium.org/chromium/src/chrome/common/extensions/api/PRESUBMIT.p....

[David Tseng, 2017-06-05 16:40:04]

On 2017/06/03 00:01:35, michaelpg wrote:
> devlin/dan: This whitelisting makes me sad (is it necessary because some
externs
> are out-of-date or something?)
> 
>
https://codereview.chromium.org/2917123002/diff/1/chrome/browser/resources/ch...
> File
>
chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js
> (left):
> 
>
https://codereview.chromium.org/2917123002/diff/1/chrome/browser/resources/ch...
>
chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js:281:
> Role.DIV,
> On 2017/06/02 21:34:34, David Tseng wrote:
> > On 2017/06/02 19:55:24, dmazzoni wrote:
> > > Why didn't the compile fail when DIV was removed?
> > > 
> > > Is our presubmit only one-way, i.e. it catches
> > > additions but not deletions?
> > 
> > No, it has to do with the externs not being re-generated when you edit an
idl
> > file.
> > Since it wasn't re-generated, the externs still had the old DIV role...
> 
> Add automation.idl to api_pair_names:
>
https://cs.chromium.org/chromium/src/chrome/common/extensions/api/PRESUBMIT.p....

Done, thanks.

[David Tseng, 2017-06-05 16:42:55]

The CQ bit was checked by dtseng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-05 16:43:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2017-06-05 17:57:17]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2017-06-05 17:57:18]

https://codereview.chromium.org/2917123002/diff/20001/chrome/common/extension...
File chrome/common/extensions/api/PRESUBMIT.py (right):

https://codereview.chromium.org/2917123002/diff/20001/chrome/common/extension...
chrome/common/extensions/api/PRESUBMIT.py:30: 'automation.idl': 'automation.js',
this was already done here, btw:
https://codereview.chromium.org/2922673003/

[David Tseng, 2017-06-05 18:15:44]

PTAL; rebased.

https://codereview.chromium.org/2917123002/diff/20001/chrome/common/extension...
File chrome/common/extensions/api/PRESUBMIT.py (right):

https://codereview.chromium.org/2917123002/diff/20001/chrome/common/extension...
chrome/common/extensions/api/PRESUBMIT.py:30: 'automation.idl': 'automation.js',
On 2017/06/05 17:57:17, Dan Beam wrote:
> this was already done here, btw:
> https://codereview.chromium.org/2922673003/

Thanks. Fixes to ChromeVox were still needed though. PTAL.

[michaelpg, 2017-06-05 19:04:25]

changes to idl and externs LGTM

[David Tseng, 2017-06-05 19:16:14]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2017-06-05 19:16:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2917123002/#ps40001
(title: "Rebase.")

[commit-bot: I haz the power, 2017-06-05 19:17:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 23:08:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-05 23:08:02]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[David Tseng, 2017-06-05 23:11:32]

The CQ bit was checked by dtseng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-05 23:12:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[David Tseng, 2017-06-06 00:49:07]

The CQ bit was unchecked by dtseng@chromium.org

[David Tseng, 2017-06-06 00:49:16]

The CQ bit was checked by dtseng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 00:49:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 03:30:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 03:30:07]

Dry run: This issue passed the CQ dry run.

[David Tseng, 2017-06-06 14:45:58]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2017-06-06 14:46:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 14:51:23]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496760358132650,
"parent_rev": "9aaa4b79c01dbf2a58f5bf7a6a8e73b7f0aeb5dc", "commit_rev":
"5af488e3095f444e1ec680c7b89dfee2c772b35b"}

[commit-bot: I haz the power, 2017-06-06 14:51:31]

Description was changed from

==========
Support role description in automation/ChromeVox

Adds support for role description throughout and fixes some errros caught by an
upgrade to the Closure compiler. Also fixes an issue caught by updating
automation externs.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Support role description in automation/ChromeVox

Adds support for role description throughout and fixes some errros caught by an
upgrade to the Closure compiler. Also fixes an issue caught by updating
automation externs.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2917123002
Cr-Commit-Position: refs/heads/master@{#477286}
Committed:
https://chromium.googlesource.com/chromium/src/+/5af488e3095f444e1ec680c7b89d...
==========

[commit-bot: I haz the power, 2017-06-06 14:51:33]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5af488e3095f444e1ec680c7b89d...