Support role description in automation/ChromeVox

chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview ChromeVox predicates for the automation extension API.
  */
 
 goog.provide('AutomationPredicate');
 goog.provide('AutomationPredicate.Binary');
@@ skipping 260 matching lines @@
 
 /**
  * Matches against a node that contains other interesting nodes.
  * These nodes should always have their subtrees scanned when navigating.
  * @param {!AutomationNode} node
  * @return {boolean}
  */
 AutomationPredicate.container = function(node) {
   return AutomationPredicate.match({
     anyRole: [
-      Role.DIV,

[dmazzoni, 2017/06/02 19:55:24]

Why didn't the compile fail when DIV was removed?

Is our presubmit only one-way, i.e. it catches
additions but not deletions?

[David Tseng, 2017/06/02 21:34:34]

No, it has to do with the externs not being re-generated when you edit an idl
file.
Since it wasn't re-generated, the externs still had the old DIV role...

[michaelpg, 2017/06/03 00:01:35]

Add automation.idl to api_pair_names:
https://cs.chromium.org/chromium/src/chrome/common/extensions/api/PRESUBMIT.p....

+      Role.GENERIC_CONTAINER,
       Role.DOCUMENT,
       Role.GROUP,
       Role.LIST_ITEM,
       Role.TOOLBAR,
       Role.WINDOW],
     anyPredicate: [
       AutomationPredicate.landmark,
       AutomationPredicate.structuralContainer,
       function(node) {
         // For example, crosh.
@@ skipping 73 matching lines @@
     return true;
 
   // Don't ignore nodes with names or name-like attribute.
   if (node.name || node.value || node.description || node.url)
     return false;
 
   // Ignore some roles.
   return AutomationPredicate.leaf(node) &&
       (AutomationPredicate.roles([Role.CLIENT,
                                   Role.COLUMN,
-                                  Role.DIV,
+                                  Role.GENERIC_CONTAINER,
                                   Role.GROUP,
                                   Role.IMAGE,
                                   Role.STATIC_TEXT,
                                   Role.SVG_ROOT,
                                   Role.TABLE_HEADER_CONTAINER,
                                   Role.UNKNOWN
                                  ])(node));
 };
 
 /**
@@ skipping 105 matching lines @@
  * Matches against nodes that we may be able to retrieve image data from.
  * @param {!AutomationNode} node
  * @return {boolean}
  */
 AutomationPredicate.supportsImageData = AutomationPredicate.roles([
     Role.CANVAS,
     Role.IMAGE,
     Role.VIDEO]);
 
 });  // goog.scope