[vpython] Allow default spec via enviornment.

[vpython] Allow default spec via enviornment.

Allow an enviornment variable to specify a default "vpython"
specification file. This will be used if no other specification file can
be found through probing.

BUG=None
TEST=None
R=iannucci@chromium.org

Review-Url: https://codereview.chromium.org/2917093003
Committed: https://github.com/luci/luci-go/commit/3815930c1099d1c3060531cb66f2274dc5c977eb

[dnj, 2017-06-03 02:48:54]

PTAL

[dnj, 2017-06-03 02:49:37]

The CQ bit was checked by dnj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-03 02:49:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-03 02:56:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-03 02:56:37]

Dry run: This issue passed the CQ dry run.

[iannucci, 2017-06-05 19:46:37]

https://codereview.chromium.org/2917093003/diff/1/vpython/application/applica...
File vpython/application/application.go (right):

https://codereview.chromium.org/2917093003/diff/1/vpython/application/applica...
vpython/application/application.go:186: D("path", a.specPath).
no D for source?

https://codereview.chromium.org/2917093003/diff/1/vpython/options.go
File vpython/options.go (right):

https://codereview.chromium.org/2917093003/diff/1/vpython/options.go#newcode163
vpython/options.go:163: o.EnvConfig.Spec = o.DefaultSpec
would it make sense to have this be by-value, then this case and the below case
collapse into one?

[dnj, 2017-06-06 13:40:40]

https://codereview.chromium.org/2917093003/diff/1/vpython/application/applica...
File vpython/application/application.go (right):

https://codereview.chromium.org/2917093003/diff/1/vpython/application/applica...
vpython/application/application.go:186: D("path", a.specPath).
On 2017/06/05 19:46:36, iannucci wrote:
> no D for source?

oops, "source" is old.

https://codereview.chromium.org/2917093003/diff/1/vpython/options.go
File vpython/options.go (right):

https://codereview.chromium.org/2917093003/diff/1/vpython/options.go#newcode163
vpython/options.go:163: o.EnvConfig.Spec = o.DefaultSpec
On 2017/06/05 19:46:36, iannucci wrote:
> would it make sense to have this be by-value, then this case and the below
case
> collapse into one?

Yeah I suppose it would. Done.

[dnj, 2017-06-06 19:32:33]

(ping)

[iannucci, 2017-06-07 18:07:25]

lgtm

[dnj, 2017-06-07 18:08:24]

The CQ bit was checked by dnj@chromium.org

[commit-bot: I haz the power, 2017-06-07 18:08:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 18:12:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 18:12:18]

Try jobs failed on following builders:
  Luci-go Linux Trusty 64 Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/369c9004104bec10)
  Luci-go Mac Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/369c9004122ee810)

[dnj (Google), 2017-06-07 18:26:50]

rebase

[dnj, 2017-06-07 18:27:01]

The CQ bit was checked by dnj@chromium.org

[dnj, 2017-06-07 18:27:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/2917093003/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-06-07 18:27:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 18:30:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 18:30:26]

Try jobs failed on following builders:
  Luci-go Linux Trusty 32-on-64 Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/369ca11dd2503910)
  Luci-go Mac Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/369ca11d17ac3110)

[dnj (Google), 2017-06-07 18:44:22]

spec load

[dnj, 2017-06-07 18:44:34]

The CQ bit was checked by dnj@chromium.org

[dnj, 2017-06-07 18:44:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/2917093003/#ps60001
(title: "spec load")

[commit-bot: I haz the power, 2017-06-07 18:44:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 18:50:21]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496861074441390,
"parent_rev": "5cf5e3db67fbf52c83ae0875d70d58ece1b73b86", "commit_rev":
"3815930c1099d1c3060531cb66f2274dc5c977eb"}

[commit-bot: I haz the power, 2017-06-07 18:50:25]

Description was changed from

==========
[vpython] Allow default spec via enviornment.

Allow an enviornment variable to specify a default "vpython"
specification file. This will be used if no other specification file can
be found through probing.

BUG=None
TEST=None
R=iannucci@chromium.org
==========

to

==========
[vpython] Allow default spec via enviornment.

Allow an enviornment variable to specify a default "vpython"
specification file. This will be used if no other specification file can
be found through probing.

BUG=None
TEST=None
R=iannucci@chromium.org

Review-Url: https://codereview.chromium.org/2917093003
Committed:
https://github.com/luci/luci-go/commit/3815930c1099d1c3060531cb66f2274dc5c977eb
==========

[commit-bot: I haz the power, 2017-06-07 18:50:26]

Committed patchset #4 (id:60001) as
https://github.com/luci/luci-go/commit/3815930c1099d1c3060531cb66f2274dc5c977eb