Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 2917053004: customtabs: Load the SharedPreferences only once, in the background. (Closed)

Created:
3 years, 6 months ago by Benoit L
Modified:
3 years, 6 months ago
Reviewers:
Yusuf
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

customtabs: Load the SharedPreferences only once, in the background. RequestThrottler needs to access SharedPreferences, triggering a StrictMode violation at the first access. Make sure that this access is from an AsyncTask, and that we execute the AsyncTask only once (for efficiency). BUG=724534 Review-Url: https://codereview.chromium.org/2917053004 Cr-Commit-Position: refs/heads/master@{#477599} Committed: https://chromium.googlesource.com/chromium/src/+/7b00acc99eb8c9b4ddffda41f9215fff02c31b0b

Patch Set 1 #

Patch Set 2 : Please FindBugs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java View 1 2 chunks +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/RequestThrottler.java View 3 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
Benoit L
3 years, 6 months ago (2017-06-02 14:29:28 UTC) #3
Benoit L
On 2017/06/02 14:29:28, Benoit L wrote: ping :-)
3 years, 6 months ago (2017-06-06 16:00:39 UTC) #11
Yusuf
lgtm
3 years, 6 months ago (2017-06-06 20:29:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2917053004/20001
3 years, 6 months ago (2017-06-07 08:24:24 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 10:06:31 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7b00acc99eb8c9b4ddffda41f921...

Powered by Google App Engine
This is Rietveld 408576698