Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2917053003: Add use counters for the experimental Budget API methods (Closed)

Created:
3 years, 6 months ago by Peter Beverloo
Modified:
3 years, 6 months ago
Reviewers:
johnme, Mike West
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, dglazkov+blink, haraken, lunalu1, picksi1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add use counters for the experimental Budget API methods This is required for running the Origin Trial. BUG=729005 Review-Url: https://codereview.chromium.org/2917053003 Cr-Commit-Position: refs/heads/master@{#476781} Committed: https://chromium.googlesource.com/chromium/src/+/3afb0d43ba189a8960efd9cf956e3cbbda991aca

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M third_party/WebKit/Source/modules/budget/BudgetService.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/platform/UseCounterFeature.def View 1 1 chunk +2 lines, -1 line 0 comments Download
M tools/metrics/histograms/enums.xml View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
Peter Beverloo
+mkwst for super trivial UseCounter addition +johnme for budget api
3 years, 6 months ago (2017-06-02 13:27:38 UTC) #2
Mike West
super trivial LGTM.
3 years, 6 months ago (2017-06-02 13:38:57 UTC) #5
johnme
lgtm https://codereview.chromium.org/2917053003/diff/1/third_party/WebKit/public/platform/UseCounterFeature.def File third_party/WebKit/public/platform/UseCounterFeature.def (right): https://codereview.chromium.org/2917053003/diff/1/third_party/WebKit/public/platform/UseCounterFeature.def#newcode1554 third_party/WebKit/public/platform/UseCounterFeature.def:1554: kBudgetAPIGetCost = 2020, Consider moving these above `// ...
3 years, 6 months ago (2017-06-02 16:09:14 UTC) #8
Peter Beverloo
Thanks both! https://codereview.chromium.org/2917053003/diff/1/third_party/WebKit/public/platform/UseCounterFeature.def File third_party/WebKit/public/platform/UseCounterFeature.def (right): https://codereview.chromium.org/2917053003/diff/1/third_party/WebKit/public/platform/UseCounterFeature.def#newcode1554 third_party/WebKit/public/platform/UseCounterFeature.def:1554: kBudgetAPIGetCost = 2020, On 2017/06/02 16:09:13, johnme ...
3 years, 6 months ago (2017-06-02 16:29:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2917053003/1
3 years, 6 months ago (2017-06-02 16:30:18 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/454517)
3 years, 6 months ago (2017-06-02 16:36:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2917053003/20001
3 years, 6 months ago (2017-06-02 17:37:53 UTC) #16
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 20:56:37 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3afb0d43ba189a8960efd9cf956e...

Powered by Google App Engine
This is Rietveld 408576698