Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 2917053002: Remove PDF XFA shutdown workaround. (Closed)

Created:
3 years, 6 months ago by Lei Zhang
Modified:
3 years, 6 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove PDF XFA shutdown workaround. PDFium fixed the XFA ownership issues in PDFium commit 2116105b. Review-Url: https://codereview.chromium.org/2917053002 Cr-Commit-Position: refs/heads/master@{#476731} Committed: https://chromium.googlesource.com/chromium/src/+/84bde8a2308225157772adf9ebe4a3ba245ffcd6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M pdf/pdfium/pdfium_engine.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Lei Zhang
3 years, 6 months ago (2017-06-02 17:14:11 UTC) #6
Tom Sepez
lgtm
3 years, 6 months ago (2017-06-02 18:10:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2917053002/1
3 years, 6 months ago (2017-06-02 18:31:28 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 18:36:32 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/84bde8a2308225157772adf9ebe4...

Powered by Google App Engine
This is Rietveld 408576698