mash: Move ShelfModel* to ash/public/cpp.

mash: Move ShelfModel* to ash/public/cpp.

ShelfModel and its observer are used by Chrome.
Move files to support the dependency correctly.

Set the AppListItem in ShelfController, not ShelfModel.
(avoids an ash/public/cpp dependency on ash/strings)

BUG=557406
TEST=NONE
R=jamescook@chromium.org
TBR=rockot@chromium.org

Review-Url: https://codereview.chromium.org/2917013002
Cr-Commit-Position: refs/heads/master@{#476769}
Committed: https://chromium.googlesource.com/chromium/src/+/109806d8e01bfe430b3305bd66c866b1029d19c0

[msw, 2017-06-02 00:35:09]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[msw, 2017-06-02 00:35:22]

Hey James, please take a look; thanks!

[commit-bot: I haz the power, 2017-06-02 00:36:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 00:43:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 00:43:55]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[msw, 2017-06-02 01:14:25]

Description was changed from

==========
mash: Move ShelfModel* to ash/public/cpp.

ShelfModel and its observer are used by Chrome.
Move files to support the dependency correctly.

BUG=557406
TEST=NONE
R=jamescook@chromium.org
==========

to

==========
mash: Move ShelfModel* to ash/public/cpp.

ShelfModel and its observer are used by Chrome.
Move files to support the dependency correctly.

Set the AppListItem in ShelfController, not ShelfModel.
(avoids an ash/public/cpp dependency on ash/strings)

BUG=557406
TEST=NONE
R=jamescook@chromium.org
==========

[msw, 2017-06-02 01:18:05]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 01:18:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 03:15:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 03:15:11]

Dry run: This issue passed the CQ dry run.

[James Cook, 2017-06-02 18:22:16]

LGTM

https://codereview.chromium.org/2917013002/diff/40001/ash/public/cpp/shelf_mo...
File ash/public/cpp/shelf_model.cc (right):

https://codereview.chromium.org/2917013002/diff/40001/ash/public/cpp/shelf_mo...
ash/public/cpp/shelf_model.cc:52: item.id = ShelfID(kAppListId);
nit: Leave a comment about who sets the title.

[msw, 2017-06-02 18:25:03]

https://codereview.chromium.org/2917013002/diff/40001/ash/public/cpp/shelf_mo...
File ash/public/cpp/shelf_model.cc (right):

https://codereview.chromium.org/2917013002/diff/40001/ash/public/cpp/shelf_mo...
ash/public/cpp/shelf_model.cc:52: item.id = ShelfID(kAppListId);
On 2017/06/02 18:22:16, James Cook wrote:
> nit: Leave a comment about who sets the title.

Done.

[msw, 2017-06-02 18:25:07]

The CQ bit was checked by msw@chromium.org

[msw, 2017-06-02 18:25:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2917013002/#ps60001
(title: "Comment on AppList item init.")

[commit-bot: I haz the power, 2017-06-02 18:25:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 18:36:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 18:36:09]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[msw, 2017-06-02 19:02:01]

Description was changed from

==========
mash: Move ShelfModel* to ash/public/cpp.

ShelfModel and its observer are used by Chrome.
Move files to support the dependency correctly.

Set the AppListItem in ShelfController, not ShelfModel.
(avoids an ash/public/cpp dependency on ash/strings)

BUG=557406
TEST=NONE
R=jamescook@chromium.org
==========

to

==========
mash: Move ShelfModel* to ash/public/cpp.

ShelfModel and its observer are used by Chrome.
Move files to support the dependency correctly.

Set the AppListItem in ShelfController, not ShelfModel.
(avoids an ash/public/cpp dependency on ash/strings)

BUG=557406
TEST=NONE
R=jamescook@chromium.org
TBR=rockot@chromium.org
==========

[msw, 2017-06-02 19:02:01]

msw@chromium.org changed reviewers:
+ rockot@chromium.org

[msw, 2017-06-02 19:02:22]

+TBR Ken for chrome/browser/extensions/OWNERS

[msw, 2017-06-02 19:02:28]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2017-06-02 19:02:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 20:11:59]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496430148261280,
"parent_rev": "29e1c03f3e5d909b2bd2a784a78bf3580bed4ccd", "commit_rev":
"109806d8e01bfe430b3305bd66c866b1029d19c0"}

[commit-bot: I haz the power, 2017-06-02 20:12:08]

Description was changed from

==========
mash: Move ShelfModel* to ash/public/cpp.

ShelfModel and its observer are used by Chrome.
Move files to support the dependency correctly.

Set the AppListItem in ShelfController, not ShelfModel.
(avoids an ash/public/cpp dependency on ash/strings)

BUG=557406
TEST=NONE
R=jamescook@chromium.org
TBR=rockot@chromium.org
==========

to

==========
mash: Move ShelfModel* to ash/public/cpp.

ShelfModel and its observer are used by Chrome.
Move files to support the dependency correctly.

Set the AppListItem in ShelfController, not ShelfModel.
(avoids an ash/public/cpp dependency on ash/strings)

BUG=557406
TEST=NONE
R=jamescook@chromium.org
TBR=rockot@chromium.org

Review-Url: https://codereview.chromium.org/2917013002
Cr-Commit-Position: refs/heads/master@{#476769}
Committed:
https://chromium.googlesource.com/chromium/src/+/109806d8e01bfe430b3305bd66c8...
==========

[commit-bot: I haz the power, 2017-06-02 20:12:10]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/109806d8e01bfe430b3305bd66c8...