Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Issue 2916973002: Fix two container issues for new login screen (Closed)

Created:
3 years, 6 months ago by Wenzhao (Colin) Zang
Modified:
3 years, 6 months ago
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, rkc
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix two container issues for new login screen 1) We need the outer-container to be scrollable when gaia screen and virtual keyboard are shown together, so the dark overlay ('login-shield') should always have the same size with the larger one of the outer-container and the scroll-container, otherwise we see areas without overlay when scrolling up. 2) We should remember to clear contents on the small pods container before rebuilding pods. BUG=718156 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2916973002 Cr-Commit-Position: refs/heads/master@{#476497} Committed: https://chromium.googlesource.com/chromium/src/+/7fb48db2c5ca7f6525489cea5c2d30cdc52c1edf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/resources/chromeos/login/md_login_shared.js View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/login/account_picker/md_user_pod_row.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Wenzhao (Colin) Zang
3 years, 6 months ago (2017-06-01 21:06:07 UTC) #5
jdufault
lgtm
3 years, 6 months ago (2017-06-01 21:10:21 UTC) #6
Wenzhao (Colin) Zang
xiyuan@, would you please look at this CL as owner? We hope to land it ...
3 years, 6 months ago (2017-06-01 22:08:38 UTC) #8
xiyuan
lgtm
3 years, 6 months ago (2017-06-01 22:28:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2916973002/1
3 years, 6 months ago (2017-06-01 22:31:35 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 00:30:12 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7fb48db2c5ca7f6525489cea5c2d...

Powered by Google App Engine
This is Rietveld 408576698