Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2916953002: WebUI: update empty-state strings for MD pages. (Closed)

Created:
3 years, 6 months ago by scottchen
Modified:
3 years, 6 months ago
CC:
chromium-reviews, srahim+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

WebUI: update empty-state strings for MD pages. TBR=grt BUG=712414 Review-Url: https://codereview.chromium.org/2916953002 Cr-Commit-Position: refs/heads/master@{#476494} Committed: https://chromium.googlesource.com/chromium/src/+/c32f05f1e460ccc7be3cd69b31fc05cccc191008

Patch Set 1 #

Total comments: 2

Patch Set 2 : update desc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/app/bookmarks_strings.grdp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M components/history_strings.grdp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (9 generated)
scottchen
3 years, 6 months ago (2017-06-01 20:28:29 UTC) #2
dschuyler
lgtm
3 years, 6 months ago (2017-06-01 20:36:16 UTC) #3
dschuyler
https://codereview.chromium.org/2916953002/diff/1/chrome/app/bookmarks_strings.grdp File chrome/app/bookmarks_strings.grdp (right): https://codereview.chromium.org/2916953002/diff/1/chrome/app/bookmarks_strings.grdp#newcode387 chrome/app/bookmarks_strings.grdp:387: To bookmark pages, click the star in the address ...
3 years, 6 months ago (2017-06-01 20:37:50 UTC) #4
scottchen
https://codereview.chromium.org/2916953002/diff/1/chrome/app/bookmarks_strings.grdp File chrome/app/bookmarks_strings.grdp (right): https://codereview.chromium.org/2916953002/diff/1/chrome/app/bookmarks_strings.grdp#newcode387 chrome/app/bookmarks_strings.grdp:387: To bookmark pages, click the star in the address ...
3 years, 6 months ago (2017-06-01 20:44:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2916953002/20001
3 years, 6 months ago (2017-06-01 20:45:28 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/453674)
3 years, 6 months ago (2017-06-01 20:56:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2916953002/20001
3 years, 6 months ago (2017-06-01 23:01:15 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 00:25:45 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c32f05f1e460ccc7be3cd69b31fc...

Powered by Google App Engine
This is Rietveld 408576698