Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2916913003: Verify story names for story sets with explicitly set names. (Closed)

Created:
3 years, 6 months ago by ashleymarie1
Modified:
3 years, 6 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Verify story names for blob story set. BUG=chromium:720002 Review-Url: https://codereview.chromium.org/2916913003 Cr-Commit-Position: refs/heads/master@{#476658} Committed: https://chromium.googlesource.com/chromium/src/+/102f414aacab02ee2d8c0087db26f90d3f484b27

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/perf/page_sets/blob_workshop.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
ashleymarie1
yay another one-line change!
3 years, 6 months ago (2017-06-01 21:18:03 UTC) #3
nednguyen
lgtm
3 years, 6 months ago (2017-06-01 21:23:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2916913003/1
3 years, 6 months ago (2017-06-02 13:58:12 UTC) #6
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 15:20:56 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/102f414aacab02ee2d8c0087db26...

Powered by Google App Engine
This is Rietveld 408576698