Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(981)

Issue 2916903006: Change HostResolverImplDnsTest.NoIPv6OnWifi to no longer leak (Closed)

Created:
3 years, 6 months ago by Ryan Hamilton
Modified:
3 years, 6 months ago
Reviewers:
mgersh, Jana
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change HostResolverImplDnsTest.NoIPv6OnWifi to no longer leak deleted resolvers into the network change notifier. BUG=729320, 728808 Review-Url: https://codereview.chromium.org/2916903006 Cr-Commit-Position: refs/heads/master@{#477013} Committed: https://chromium.googlesource.com/chromium/src/+/ce64e673564b8a2b0912c07567e96c97aa4dca06

Patch Set 1 #

Patch Set 2 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M net/dns/host_resolver_impl_unittest.cc View 1 1 chunk +6 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Ryan Hamilton
mgersh: I think you originally wrote this test and seem to be the owner of ...
3 years, 6 months ago (2017-06-03 15:09:59 UTC) #3
mgersh
Wow, thanks for figuring that out! lgtm.
3 years, 6 months ago (2017-06-05 14:44:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2916903006/20001
3 years, 6 months ago (2017-06-05 16:48:31 UTC) #6
commit-bot: I haz the power
3 years, 6 months ago (2017-06-05 17:42:14 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ce64e673564b8a2b0912c07567e9...

Powered by Google App Engine
This is Rietveld 408576698