Handle int constant

Handle int constant

Prerequisites:
- move constants for emission to CodegenWorldBuilder
- use entities in custom elements analysis
- mostly use entities in lookup map analysis
- use entities in codegen listener
- use more entities in mirrors data

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/586a465c45db7d1ec7498b8c1df9cc8d245e8e61

[Johnni Winther, 2017-06-01 14:09:36]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-06-01 22:28:44]

LGTM

https://codereview.chromium.org/2916893002/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart (left):

https://codereview.chromium.org/2916893002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart:242:
constructor.computeType(_resolution);
is computeType not needed anymore?

https://codereview.chromium.org/2916893002/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart (right):

https://codereview.chromium.org/2916893002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart:5: //import
'../common/resolution.dart';
delete (and below)

https://codereview.chromium.org/2916893002/diff/1/pkg/compiler/lib/src/univer...
File pkg/compiler/lib/src/universe/codegen_world_builder.dart (right):

https://codereview.chromium.org/2916893002/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/codegen_world_builder.dart:56: ///  appear before
the dependent constant.  [preSortCompare] is a comparator
nit: remove extra whitespace at the beginning of this line and every line below.

https://codereview.chromium.org/2916893002/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/codegen_world_builder.dart:500: /** Set of all
registered compiled constants. */
nit: switch to ///

https://codereview.chromium.org/2916893002/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/codegen_world_builder.dart:508: * Returns a list
of constants topologically sorted so that dependencies
delete comment? (use @override)

[Johnni Winther, 2017-06-02 11:17:24]

https://codereview.chromium.org/2916893002/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart (left):

https://codereview.chromium.org/2916893002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart:242:
constructor.computeType(_resolution);
On 2017/06/01 22:28:43, Siggi Cherem (dart-lang) wrote:
> is computeType not needed anymore?

Good call, it might.

https://codereview.chromium.org/2916893002/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart (right):

https://codereview.chromium.org/2916893002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart:5: //import
'../common/resolution.dart';
On 2017/06/01 22:28:43, Siggi Cherem (dart-lang) wrote:
> delete (and below)

Done.

https://codereview.chromium.org/2916893002/diff/1/pkg/compiler/lib/src/univer...
File pkg/compiler/lib/src/universe/codegen_world_builder.dart (right):

https://codereview.chromium.org/2916893002/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/codegen_world_builder.dart:56: ///  appear before
the dependent constant.  [preSortCompare] is a comparator
On 2017/06/01 22:28:43, Siggi Cherem (dart-lang) wrote:
> nit: remove extra whitespace at the beginning of this line and every line
below.

Done.

https://codereview.chromium.org/2916893002/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/codegen_world_builder.dart:500: /** Set of all
registered compiled constants. */
On 2017/06/01 22:28:43, Siggi Cherem (dart-lang) wrote:
> nit: switch to ///

Done.

https://codereview.chromium.org/2916893002/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/codegen_world_builder.dart:508: * Returns a list
of constants topologically sorted so that dependencies
On 2017/06/01 22:28:43, Siggi Cherem (dart-lang) wrote:
> delete comment? (use @override)

Done.

[Johnni Winther, 2017-06-02 11:32:37]

Description was changed from

==========
Handle int constant

Prerequisites:
- move constants for emission to CodegenWorldBuilder
- use entities in custom elements analysis
- mostly use entities in lookup map analysis
- use entities in codegen listener
- use more entities in mirrors data
==========

to

==========
Handle int constant

Prerequisites:
- move constants for emission to CodegenWorldBuilder
- use entities in custom elements analysis
- mostly use entities in lookup map analysis
- use entities in codegen listener
- use more entities in mirrors data

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/586a465c45db7d1ec7498b8c1df9cc8d245e8e61
==========

[Johnni Winther, 2017-06-02 11:32:38]

Committed patchset #2 (id:20001) manually as
586a465c45db7d1ec7498b8c1df9cc8d245e8e61 (presubmit successful).