Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: pkg/compiler/lib/src/js_backend/mirrors_data.dart

Issue 2916893002: Handle int constant (Closed)
Patch Set: Updated cf. comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/mirrors_data.dart
diff --git a/pkg/compiler/lib/src/js_backend/mirrors_data.dart b/pkg/compiler/lib/src/js_backend/mirrors_data.dart
index 58de57d8c7c93748e67898dbcede09477eed4467..e2505bd1f8f2a991c7904d52571761725bfa5072 100644
--- a/pkg/compiler/lib/src/js_backend/mirrors_data.dart
+++ b/pkg/compiler/lib/src/js_backend/mirrors_data.dart
@@ -305,7 +305,8 @@ class MirrorsDataImpl implements MirrorsData, MirrorsDataBuilder {
for (MetadataAnnotation metadata in element.metadata) {
metadata.ensureResolved(_compiler.resolution);
ConstantValue constant = _constants.getConstantValueForMetadata(metadata);
- _constants.addCompileTimeConstantForEmission(constant);
+ CodegenWorldBuilder worldBuilder = _compiler.codegenWorldBuilder;
+ worldBuilder.addCompileTimeConstantForEmission(constant);
}
}
@@ -376,7 +377,7 @@ class MirrorsDataImpl implements MirrorsData, MirrorsDataBuilder {
}
@override
- bool isClassAccessibleByReflection(ClassElement element) {
+ bool isClassAccessibleByReflection(ClassEntity element) {
return _classesNeededForReflection.contains(_getDartClass(element));
}
@@ -389,7 +390,8 @@ class MirrorsDataImpl implements MirrorsData, MirrorsDataBuilder {
if (element.isLibrary) {
return false;
} else if (element.isClass) {
- return isClassAccessibleByReflection(element);
+ ClassElement cls = element;
+ return isClassAccessibleByReflection(cls);
} else if (element.isTypedef) {
return isTypedefAccessibleByReflection(element);
} else {
@@ -398,7 +400,7 @@ class MirrorsDataImpl implements MirrorsData, MirrorsDataBuilder {
}
}
- ClassElement _getDartClass(ClassElement cls) {
+ ClassEntity _getDartClass(ClassEntity cls) {
if (cls == _commonElements.jsIntClass) {
return _commonElements.intClass;
} else if (cls == _commonElements.jsBoolClass) {

Powered by Google App Engine
This is Rietveld 408576698