Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 2916873003: [Sync] Create iOS factory for UserEventService. (Closed)

Created:
3 years, 6 months ago by skym
Modified:
3 years, 6 months ago
Reviewers:
napper, Patrick Noland
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, marq+watch_chromium.org, noyau+watch_chromium.org, sync-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Create iOS factory for UserEventService. This is essentially a clone of UserEventServiceFactory that uses web::BrowserState to be iOS compatible. BUG=701032 Review-Url: https://codereview.chromium.org/2916873003 Cr-Commit-Position: refs/heads/master@{#476515} Committed: https://chromium.googlesource.com/chromium/src/+/62433b1aac27d4652b1bff4a6e0e424b4bac9edf

Patch Set 1 #

Patch Set 2 : Fix base constructor call. #

Patch Set 3 : Use NoOpUserEventService when IsOffTheRecord. #

Patch Set 4 : Fix compile. #

Patch Set 5 : Fix compile 2. #

Patch Set 6 : Fix compile 3. #

Patch Set 7 : Fix compile 4. #

Patch Set 8 : Remove an accidental ios_chrome_profile_sync_service_factory.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -1 line) Patch
M ios/chrome/browser/sync/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A ios/chrome/browser/sync/ios_user_event_service_factory.h View 1 2 3 1 chunk +47 lines, -0 lines 0 comments Download
A ios/chrome/browser/sync/ios_user_event_service_factory.cc View 1 2 3 4 5 6 1 chunk +69 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
skym
PTAL
3 years, 6 months ago (2017-06-01 23:17:43 UTC) #6
Patrick Noland
lgtm
3 years, 6 months ago (2017-06-01 23:24:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2916873003/140001
3 years, 6 months ago (2017-06-01 23:27:43 UTC) #10
napper
lgtm
3 years, 6 months ago (2017-06-01 23:29:46 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 01:31:53 UTC) #15
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/62433b1aac27d4652b1bff4a6e0e...

Powered by Google App Engine
This is Rietveld 408576698