Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2916873002:
Add suppressions for upcoming Skia DEPS roll (Closed)
|
Created:
3 years, 6 months ago by robertphillips Modified:
3 years, 6 months ago CC:
chromium-reviews, blink-reviews, herb_g Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd suppressions for upcoming Skia DEPS roll
TBR=fmalita@chromium.org
BUG=728566
Review-Url: https://codereview.chromium.org/2916873002
Cr-Commit-Position: refs/heads/master@{#476264}
Committed: https://chromium.googlesource.com/chromium/src/+/84ca44746a87520343acd76a40d51b948d9e56a8
Patch Set 1 #
Messages
Total messages: 18 (13 generated)
Description was changed from ========== Add suppressions for upcoming Skia DEPS roll BUG=728566 ========== to ========== Add suppressions for upcoming Skia DEPS roll BUG=728566 ==========
robertphillips@google.com changed reviewers: + fmalita@chromium.org, reed@chromium.org
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Add suppressions for upcoming Skia DEPS roll BUG=728566 ========== to ========== Add suppressions for upcoming Skia DEPS roll TBR=fmalita@chromium.org BUG=728566 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robertphillips@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
reed@google.com changed reviewers: + reed@google.com
lgtm
The CQ bit was checked by reed@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1496322570803940, "parent_rev":
"3543d97ca7a33fb8ad48261ad252428555747896", "commit_rev":
"84ca44746a87520343acd76a40d51b948d9e56a8"}
Message was sent while issue was closed.
Description was changed from ========== Add suppressions for upcoming Skia DEPS roll TBR=fmalita@chromium.org BUG=728566 ========== to ========== Add suppressions for upcoming Skia DEPS roll TBR=fmalita@chromium.org BUG=728566 Review-Url: https://codereview.chromium.org/2916873002 Cr-Commit-Position: refs/heads/master@{#476264} Committed: https://chromium.googlesource.com/chromium/src/+/84ca44746a87520343acd76a40d5... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/84ca44746a87520343acd76a40d5... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
